Open
Conversation
fdebijl
reviewed
Feb 10, 2021
twitter.js
Outdated
|
|
||
| module.exports = Twitter; | ||
|
|
||
| Twitter.default = Twitter; |
Collaborator
There was a problem hiding this comment.
Shouldn't this line be moved above module.exports, or is it hoisted?
kissarat
commented
Mar 7, 2021
Author
kissarat
left a comment
There was a problem hiding this comment.
Maybe such code are more clear, but it's not possible to put module.exports.default = Twitter before module.exports = Twitter
Author
|
@fdebijl I'm not sure that I'm not sure that I understand you well, but I made an appropriate changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There declaration in
index.d.tsBut without this PR it is impossible to import this way
Because for exporting
Import must looks like
But it's not described in
index.d.ts