Gate exception field serialization behind langversion 11

[T-Gro]

Gates the GetObjectData + field-restoring ctor from #19342 behind LanguageFeature.ExceptionFieldSerializationSupport (F# 11).

With langversion ≤10 (current default), exception codegen is unchanged from pre-#19342 behavior.

[github-actions]

❗ Release notes required

@T-Gro,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path	Release notes path	Description
LanguageFeatures.fsi	docs/release-notes/.Language/preview.md	No release notes found or release notes format is not correct

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
src/Compiler	docs/release-notes/.FSharp.Compiler.Service/11.0.100.md

[github-actions]

Commit pushed: 4ee810c

Generated by LabelOps — PR Maintenance

[github-actions]

Commit pushed: 1a04573

Generated by LabelOps — PR Maintenance

[github-actions]

Commit pushed: f1a9d69

Generated by LabelOps — PR Maintenance

[github-actions]

🤖 LabelOps — CI Fix.

The EmittedIL.NullnessMetadata.Nullable attr for exception types test was failing on WindowsNoRealsig_testDesktop and WindowsCompressedMetadata_Desktop Batch2 (net472).

Root cause: The ExceptionType.fs.il.net472.bsl baseline was incorrectly updated to use [runtime]-prefixed NullableContextAttribute and NullableAttribute references. On net472, these attributes are embedded in the assembly (not referenced from the BCL), so they must not have the [runtime] prefix. The embedded attribute class definitions at the end of the file were also incorrectly removed.

Fixed the baseline to keep the non-prefixed attribute references and embedded class definitions, while preserving the correct serialization changes (simplified ctor, no GetObjectData) for default langversion.

Generated by LabelOps — PR Maintenance · ● 103.1M · ◷

[T-Gro]

Review: Gate exception field serialization behind langversion 11

This is a well-structured PR that properly gates the behavioral change from #19342 behind LanguageFeature.ExceptionFieldSerializationSupport (F# 11). The approach is sound — emitting GetObjectData and the field-restoring deserialization ctor changes the binary contract of exception types, so gating it is the right call for backward compatibility.

What's good

• Clean gating logic: The emitFieldSerialization boolean at line 12320-12323 is easy to follow and correctly combines langversion check, FSharp.Core exclusion, and empty-fields short-circuit.
• Test coverage: The runtime roundtrip tests and the MessageFieldCollision regression test explicitly opt into langversion 11. The FSharp.Core negative test (Issue_878_FSharpCoreExceptions_NoGetObjectDataOverride) correctly validates that FSharp.Core exceptions are still excluded.
• Baseline IL updates: All baselines that compile at default langversion correctly no longer contain GetObjectData / field-restore IL — this proves the gate works for the default path.
• Release notes: Properly updated to mention the langversion gate.
• Code structure improvement: Moving ilInstrsToSaveFields, ilInstrsForGetObjectData, and ilGetObjectDataDef inside the if emitFieldSerialization then branch avoids constructing those values when they'll never be used.

Minor observations (non-blocking)

1. ilInstrsToRestoreFields still computed unconditionally (lines 12286-12318): Unlike the save/GetObjectData side which was moved inside the if, the restore instructions are computed even when emitFieldSerialization = false. The list is just discarded via the if ... then ilInstrsToRestoreFields else [] at line 12332. Consider moving it inside the branch for symmetry and to avoid the allocation in the common (langversion < 11) path. Not a correctness issue.

2. No explicit negative test: The IL baselines implicitly prove that default langversion doesn't emit field serialization, but an explicit [<Fact>] that compiles an exception at langversion 10 and asserts absence of GetObjectData would be stronger documentation of intent. The existing coverage via Nullness/SerializableAttribute baselines is adequate though.

Overall: clean, minimal, correct.