Remove obsolete SetAndroidSupportedAbis usage from test code#11390
Merged
jonathanpeppers merged 2 commits intoMay 18, 2026
Conversation
6 tasks
…and remove obsolete methods Agent-Logs-Url: https://github.com/dotnet/android/sessions/bf2f73b1-2c2b-4c71-bac8-b0236134e8c2 Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove obsolete SetAndroidSupportedAbis usage from test code
Remove obsolete May 18, 2026
SetAndroidSupportedAbis usage from test code
Contributor
There was a problem hiding this comment.
Pull request overview
Mechanical refactor that removes the obsolete SetAndroidSupportedAbis test helper extension and migrates all call sites to the existing SetRuntimeIdentifiers API. Since SetAndroidSupportedAbis was already a thin wrapper around SetRuntimeIdentifiers, there is no behavioral change.
Changes:
- Deleted both
[Obsolete]SetAndroidSupportedAbisoverloads fromProjectExtensions.cs. - Migrated 49 call sites across 18 test files, using
new[] { ... }for single-ABI/params cases,.Split(';')for semicolon-delimited strings, and passing arrays directly otherwise.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Utilities/ProjectExtensions.cs | Removes obsolete params/string overloads. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AotTests.cs | Migrates 3 call sites. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest.cs | Migrates 2 call sites. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest2.cs | Migrates single-ABI call. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/EnvironmentContentTests.cs | Migrates string-ABI calls via Split. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/IncrementalBuildTest.cs | Migrates 4 call sites. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/ManifestTest.cs | Migrates string-ABI call via Split. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/PackagingTest.cs | Migrates 2 call sites. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Tasks/LinkerTests.cs | Migrates single-literal call. |
| tests/MSBuildDeviceIntegration/Tests/AotProfileTests.cs | Migrates DeviceAbi call. |
| tests/MSBuildDeviceIntegration/Tests/BundleToolTests.cs | Migrates Abis array call. |
| tests/MSBuildDeviceIntegration/Tests/DebuggingTest.cs | Migrates 3 call sites. |
| tests/MSBuildDeviceIntegration/Tests/InstallAndRunTests.cs | Migrates 13 call sites. |
| tests/MSBuildDeviceIntegration/Tests/InstallTests.cs | Migrates 8 call sites. |
| tests/MSBuildDeviceIntegration/Tests/MarshalMethodsGCHangTests.cs | Migrates DeviceAbi call. |
| tests/MSBuildDeviceIntegration/Tests/MonoAndroidExportTest.cs | Migrates 2 call sites. |
| tests/MSBuildDeviceIntegration/Tests/PerformanceTest.cs | Migrates DeviceAbi call. |
| tests/MSBuildDeviceIntegration/Tests/SystemApplicationTests.cs | Migrates DeviceAbi call. |
jonathanpeppers
approved these changes
May 18, 2026
Member
jonathanpeppers
left a comment
There was a problem hiding this comment.
Test failures unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate all 49 call sites of the deprecated
SetAndroidSupportedAbisextension methods toSetRuntimeIdentifiersand remove the obsolete method definitions.Changes
DeviceAbi,abi,supportedAbi) →new[] { variable }supportedAbis) →variable.Split (';')abis,Abis) → passed directlynew[] { ... }[Obsolete] SetAndroidSupportedAbisoverloads fromProjectExtensions.csExample
No behavioral change —
SetAndroidSupportedAbiswas already a trivial wrapper aroundSetRuntimeIdentifiers.