Skip to content

Fix indentation: convert spaces to tabs in Xamarin.Android.Build.Tasks source files #11375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix indentation: convert spaces to tabs in Xamarin.Android.Build.Tasks source files #11375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70539b7
Initial plan
Copilot May 15, 2026
e2696e1
Fix indentation: convert spaces to tabs in 6 Xamarin.Android.Build.Ta…
Copilot May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
392 changes: 196 additions & 196 deletions src/Xamarin.Android.Build.Tasks/Tasks/GetAvailableAndroidDevices.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,200 +22,200 @@ namespace Xamarin.Android.Tasks;
/// </summary>
public class GetAvailableAndroidDevices : AndroidAdb
{
readonly List<string> output = [];

/// <summary>
/// Path to the emulator tool directory.
/// </summary>
public string EmulatorToolPath { get; set; } = "";

/// <summary>
/// Filename of the emulator executable (e.g., "emulator" or "emulator.exe").
/// </summary>
public string EmulatorToolExe { get; set; } = "";

[Output]
public ITaskItem [] Devices { get; set; } = [];

public GetAvailableAndroidDevices ()
{
Command = "devices";
Arguments = "-l";
}

protected override void LogEventsFromTextOutput (string singleLine, MessageImportance messageImportance)
{
base.LogEventsFromTextOutput (singleLine, messageImportance);
output.Add (singleLine);
}

protected override void LogToolCommand (string message) => Log.LogDebugMessage (message);

public override bool RunTask ()
{
if (!base.RunTask ())
return false;

// Parse devices from adb using shared AdbRunner logic
var adbDevices = AdbRunner.ParseAdbDevicesOutput (output);
Log.LogDebugMessage ($"Found {adbDevices.Count} device(s) from adb");

// For emulators, query AVD names
var logger = this.CreateTaskLogger ();
foreach (var device in adbDevices) {
if (device.Type == AdbDeviceType.Emulator) {
device.AvdName = GetEmulatorAvdName (device.Serial);
device.Description = AdbRunner.BuildDeviceDescription (device, logger);
}
}

// Get available emulators from 'emulator -list-avds'
var availableEmulators = GetAvailableEmulators ();
Log.LogDebugMessage ($"Found {availableEmulators.Count} available emulator(s) from 'emulator -list-avds'");

// Merge using shared logic
var mergedDevices = AdbRunner.MergeDevicesAndEmulators (adbDevices, availableEmulators, logger);

// Filter: if any online devices exist, return only those so auto-selection works
// when a single device is running. If none are online, return all (including
// non-running emulators) so the user can pick one to boot.
var filteredDevices = FilterDevicesForSelection (mergedDevices);
Log.LogDebugMessage ($"Filtered from {mergedDevices.Count} to {filteredDevices.Count} device(s) (online devices take priority)");

// Convert to ITaskItem array
Devices = ConvertToTaskItems (filteredDevices);

Log.LogDebugMessage ($"Total {Devices.Length} Android device(s)/emulator(s) after filtering");

return !Log.HasLoggedErrors;
}

/// <summary>
/// Filters the merged device list for device selection:
/// - If any online devices exist, returns only those (so auto-selection works with a single running device)
/// - If no online devices exist, returns all (including non-running emulators for user selection)
/// </summary>
internal static IReadOnlyList<AdbDeviceInfo> FilterDevicesForSelection (IReadOnlyList<AdbDeviceInfo> devices)
{
var onlineDevices = new List<AdbDeviceInfo> (devices.Count);
foreach (var device in devices) {
if (device.Status == AdbDeviceStatus.Online) {
onlineDevices.Add (device);
}
}

if (onlineDevices.Count == 0)
return devices;

return onlineDevices;
}

/// <summary>
/// Converts AdbDeviceInfo list to ITaskItem array for MSBuild output.
/// </summary>
internal static ITaskItem [] ConvertToTaskItems (IReadOnlyList<AdbDeviceInfo> devices)
{
var items = new ITaskItem [devices.Count];
for (int i = 0; i < devices.Count; i++) {
var device = devices [i];
var item = new TaskItem (device.Serial);
item.SetMetadata ("Description", device.Description);
item.SetMetadata ("Type", device.Type.ToString ());
item.SetMetadata ("Status", device.Status.ToString ());

if (!device.AvdName.IsNullOrEmpty ())
item.SetMetadata ("AvdName", device.AvdName);
if (!device.Model.IsNullOrEmpty ())
item.SetMetadata ("Model", device.Model);
if (!device.Product.IsNullOrEmpty ())
item.SetMetadata ("Product", device.Product);
if (!device.Device.IsNullOrEmpty ())
item.SetMetadata ("Device", device.Device);
if (!device.TransportId.IsNullOrEmpty ())
item.SetMetadata ("TransportId", device.TransportId);

items [i] = item;
}
return items;
}

/// <summary>
/// Gets the list of available AVDs using 'emulator -list-avds'.
/// </summary>
protected virtual List<string> GetAvailableEmulators ()
{
var emulators = new List<string> ();

if (EmulatorToolPath.IsNullOrEmpty () || EmulatorToolExe.IsNullOrEmpty ()) {
Log.LogDebugMessage ("EmulatorToolPath or EmulatorToolExe not set, skipping emulator listing");
return emulators;
}

var emulatorPath = Path.Combine (EmulatorToolPath, EmulatorToolExe);
if (!File.Exists (emulatorPath)) {
Log.LogDebugMessage ($"Emulator tool not found at: {emulatorPath}");
return emulators;
}

try {
var exitCode = MonoAndroidHelper.RunProcess (
emulatorPath,
"-list-avds",
Log,
onOutput: (sender, e) => {
if (!e.Data.IsNullOrWhiteSpace ()) {
var avdName = e.Data.Trim ();
emulators.Add (avdName);
Log.LogDebugMessage ($"Found available emulator: {avdName}");
}
},
logWarningOnFailure: false
);

if (exitCode != 0) {
Log.LogDebugMessage ($"'emulator -list-avds' returned exit code: {exitCode}");
}
} catch (Exception ex) {
Log.LogDebugMessage ($"Failed to run 'emulator -list-avds': {ex.Message}");
}

return emulators;
}

/// <summary>
/// Queries the emulator for its AVD name using 'adb -s &lt;serial&gt; emu avd name'.
/// Returns the raw AVD name (not formatted).
/// </summary>
protected virtual string? GetEmulatorAvdName (string serial)
{
try {
var adbPath = Path.Combine (ToolPath, ToolExe);
var outputLines = new List<string> ();

var exitCode = MonoAndroidHelper.RunProcess (
adbPath,
$"-s {serial} emu avd name",
Log,
onOutput: (sender, e) => {
if (!e.Data.IsNullOrEmpty ()) {
outputLines.Add (e.Data);
}
},
logWarningOnFailure: false
);

if (exitCode == 0 && outputLines.Count > 0) {
var avdName = outputLines [0].Trim ();
// Verify it's not the "OK" response
if (!avdName.IsNullOrEmpty () && !avdName.Equals ("OK", StringComparison.OrdinalIgnoreCase)) {
Log.LogDebugMessage ($"Emulator {serial} has AVD name: {avdName}");
return avdName;
}
}
} catch (Exception ex) {
Log.LogDebugMessage ($"Failed to get AVD name for {serial}: {ex.Message}");
}

return null;
}
readonly List<string> output = [];

/// <summary>
/// Path to the emulator tool directory.
/// </summary>
public string EmulatorToolPath { get; set; } = "";

/// <summary>
/// Filename of the emulator executable (e.g., "emulator" or "emulator.exe").
/// </summary>
public string EmulatorToolExe { get; set; } = "";

[Output]
public ITaskItem [] Devices { get; set; } = [];

public GetAvailableAndroidDevices ()
{
Command = "devices";
Arguments = "-l";
}

protected override void LogEventsFromTextOutput (string singleLine, MessageImportance messageImportance)
{
base.LogEventsFromTextOutput (singleLine, messageImportance);
output.Add (singleLine);
}

protected override void LogToolCommand (string message) => Log.LogDebugMessage (message);

public override bool RunTask ()
{
if (!base.RunTask ())
return false;

// Parse devices from adb using shared AdbRunner logic
var adbDevices = AdbRunner.ParseAdbDevicesOutput (output);
Log.LogDebugMessage ($"Found {adbDevices.Count} device(s) from adb");

// For emulators, query AVD names
var logger = this.CreateTaskLogger ();
foreach (var device in adbDevices) {
if (device.Type == AdbDeviceType.Emulator) {
device.AvdName = GetEmulatorAvdName (device.Serial);
device.Description = AdbRunner.BuildDeviceDescription (device, logger);
}
}

// Get available emulators from 'emulator -list-avds'
var availableEmulators = GetAvailableEmulators ();
Log.LogDebugMessage ($"Found {availableEmulators.Count} available emulator(s) from 'emulator -list-avds'");

// Merge using shared logic
var mergedDevices = AdbRunner.MergeDevicesAndEmulators (adbDevices, availableEmulators, logger);

// Filter: if any online devices exist, return only those so auto-selection works
// when a single device is running. If none are online, return all (including
// non-running emulators) so the user can pick one to boot.
var filteredDevices = FilterDevicesForSelection (mergedDevices);
Log.LogDebugMessage ($"Filtered from {mergedDevices.Count} to {filteredDevices.Count} device(s) (online devices take priority)");

// Convert to ITaskItem array
Devices = ConvertToTaskItems (filteredDevices);

Log.LogDebugMessage ($"Total {Devices.Length} Android device(s)/emulator(s) after filtering");

return !Log.HasLoggedErrors;
}

/// <summary>
/// Filters the merged device list for device selection:
/// - If any online devices exist, returns only those (so auto-selection works with a single running device)
/// - If no online devices exist, returns all (including non-running emulators for user selection)
/// </summary>
internal static IReadOnlyList<AdbDeviceInfo> FilterDevicesForSelection (IReadOnlyList<AdbDeviceInfo> devices)
{
var onlineDevices = new List<AdbDeviceInfo> (devices.Count);
foreach (var device in devices) {
if (device.Status == AdbDeviceStatus.Online) {
onlineDevices.Add (device);
}
}

if (onlineDevices.Count == 0)
return devices;

return onlineDevices;
}

/// <summary>
/// Converts AdbDeviceInfo list to ITaskItem array for MSBuild output.
/// </summary>
internal static ITaskItem [] ConvertToTaskItems (IReadOnlyList<AdbDeviceInfo> devices)
{
var items = new ITaskItem [devices.Count];
for (int i = 0; i < devices.Count; i++) {
var device = devices [i];
var item = new TaskItem (device.Serial);
item.SetMetadata ("Description", device.Description);
item.SetMetadata ("Type", device.Type.ToString ());
item.SetMetadata ("Status", device.Status.ToString ());

if (!device.AvdName.IsNullOrEmpty ())
item.SetMetadata ("AvdName", device.AvdName);
if (!device.Model.IsNullOrEmpty ())
item.SetMetadata ("Model", device.Model);
if (!device.Product.IsNullOrEmpty ())
item.SetMetadata ("Product", device.Product);
if (!device.Device.IsNullOrEmpty ())
item.SetMetadata ("Device", device.Device);
if (!device.TransportId.IsNullOrEmpty ())
item.SetMetadata ("TransportId", device.TransportId);

items [i] = item;
}
return items;
}

/// <summary>
/// Gets the list of available AVDs using 'emulator -list-avds'.
/// </summary>
protected virtual List<string> GetAvailableEmulators ()
{
var emulators = new List<string> ();

if (EmulatorToolPath.IsNullOrEmpty () || EmulatorToolExe.IsNullOrEmpty ()) {
Log.LogDebugMessage ("EmulatorToolPath or EmulatorToolExe not set, skipping emulator listing");
return emulators;
}

var emulatorPath = Path.Combine (EmulatorToolPath, EmulatorToolExe);
if (!File.Exists (emulatorPath)) {
Log.LogDebugMessage ($"Emulator tool not found at: {emulatorPath}");
return emulators;
}

try {
var exitCode = MonoAndroidHelper.RunProcess (
emulatorPath,
"-list-avds",
Log,
onOutput: (sender, e) => {
if (!e.Data.IsNullOrWhiteSpace ()) {
var avdName = e.Data.Trim ();
emulators.Add (avdName);
Log.LogDebugMessage ($"Found available emulator: {avdName}");
}
},
logWarningOnFailure: false
);

if (exitCode != 0) {
Log.LogDebugMessage ($"'emulator -list-avds' returned exit code: {exitCode}");
}
} catch (Exception ex) {
Log.LogDebugMessage ($"Failed to run 'emulator -list-avds': {ex.Message}");
}

return emulators;
}

/// <summary>
/// Queries the emulator for its AVD name using 'adb -s &lt;serial&gt; emu avd name'.
/// Returns the raw AVD name (not formatted).
/// </summary>
protected virtual string? GetEmulatorAvdName (string serial)
{
try {
var adbPath = Path.Combine (ToolPath, ToolExe);
var outputLines = new List<string> ();

var exitCode = MonoAndroidHelper.RunProcess (
adbPath,
$"-s {serial} emu avd name",
Log,
onOutput: (sender, e) => {
if (!e.Data.IsNullOrEmpty ()) {
outputLines.Add (e.Data);
}
},
logWarningOnFailure: false
);

if (exitCode == 0 && outputLines.Count > 0) {
var avdName = outputLines [0].Trim ();
// Verify it's not the "OK" response
if (!avdName.IsNullOrEmpty () && !avdName.Equals ("OK", StringComparison.OrdinalIgnoreCase)) {
Log.LogDebugMessage ($"Emulator {serial} has AVD name: {avdName}");
return avdName;
}
}
} catch (Exception ex) {
Log.LogDebugMessage ($"Failed to get AVD name for {serial}: {ex.Message}");
}

return null;
}
}
Loading