[build] Remove 15 unused internal build tasks#11369
Open
jonathanpeppers wants to merge 1 commit into
Open
Conversation
Remove dead-code MSBuild tasks from xa-prep-tasks and BootstrapTasks that are no longer referenced anywhere in the build system. xa-prep-tasks (12 removed): - AcceptAndroidSdkLicenses, CheckoutExternalGitDependency, CreateFilePaths, GitCommitTime, GitDiff, HashFileContents, NDKInfo, ParseExternalGitDependencies, PrepareInstall, RunParallelTargets, SetEnvironmentVariable, SystemUnzip BootstrapTasks (3 removed): - CreateFrameworkList, GenerateMonoDroidIncludes, GenerateProfile Also removed stale <UsingTask> declarations for GitCommitTime (XAVersionInfo.targets) and GenerateProfile (Xamarin.Android.Build.Tasks.targets). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
added
the
ready-to-review
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes dead-code MSBuild task implementations from the internal build-task projects (xa-prep-tasks and Xamarin.Android.Tools.BootstrapTasks) and cleans up stale <UsingTask> declarations that referenced them.
Changes:
- Removed 12 unused
xa-prep-taskstask implementations and 3 unusedBootstrapTasksimplementations. - Removed stale
<UsingTask>entries forGitCommitTimeandGenerateProfile. - Updated an internal build comment in
Xamarin.Android.Build.Tasks.csprojto reference a still-used task.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.targets | Removes the stale <UsingTask> for Xamarin.Android.Tools.BootstrapTasks.GenerateProfile. |
| src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj | Updates the comment to reference <GenerateSupportedPlatforms/> instead of <GenerateProfile/>. |
| build-tools/Xamarin.Android.Tools.BootstrapTasks/Xamarin.Android.Tools.BootstrapTasks/GenerateProfile.cs | Deletes unused BootstrapTasks task implementation. |
| build-tools/Xamarin.Android.Tools.BootstrapTasks/Xamarin.Android.Tools.BootstrapTasks/GenerateMonoDroidIncludes.cs | Deletes unused BootstrapTasks task implementation. |
| build-tools/Xamarin.Android.Tools.BootstrapTasks/Xamarin.Android.Tools.BootstrapTasks/CreateFrameworkList.cs | Deletes unused BootstrapTasks task implementation. |
| build-tools/xa-prep-tasks/Xamarin.Android.BuildTools.PrepTasks/SystemUnzip.cs | Deletes unused prep task implementation. |
| build-tools/xa-prep-tasks/Xamarin.Android.BuildTools.PrepTasks/SetEnvironmentVariable.cs | Deletes unused prep task implementation. |
| build-tools/xa-prep-tasks/Xamarin.Android.BuildTools.PrepTasks/RunParallelTargets.cs | Deletes unused prep task implementation. |
| build-tools/xa-prep-tasks/Xamarin.Android.BuildTools.PrepTasks/PrepareInstall.cs | Deletes unused prep task implementation. |
| build-tools/xa-prep-tasks/Xamarin.Android.BuildTools.PrepTasks/ParseExternalGitDependencies.cs | Deletes unused prep task implementation. |
| build-tools/xa-prep-tasks/Xamarin.Android.BuildTools.PrepTasks/NDKInfo.cs | Deletes unused prep task implementation. |
| build-tools/xa-prep-tasks/Xamarin.Android.BuildTools.PrepTasks/HashFileContents.cs | Deletes unused prep task implementation. |
| build-tools/xa-prep-tasks/Xamarin.Android.BuildTools.PrepTasks/GitDiff.cs | Deletes unused prep task implementation. |
| build-tools/xa-prep-tasks/Xamarin.Android.BuildTools.PrepTasks/GitCommitTime.cs | Deletes unused prep task implementation. |
| build-tools/xa-prep-tasks/Xamarin.Android.BuildTools.PrepTasks/CreateFilePaths.cs | Deletes unused prep task implementation. |
| build-tools/xa-prep-tasks/Xamarin.Android.BuildTools.PrepTasks/CheckoutExternalGitDependency.cs | Deletes unused prep task implementation. |
| build-tools/xa-prep-tasks/Xamarin.Android.BuildTools.PrepTasks/AcceptAndroidSdkLicenses.cs | Deletes unused prep task implementation. |
| build-tools/scripts/XAVersionInfo.targets | Removes stale <UsingTask> entry for Xamarin.Android.BuildTools.PrepTasks.GitCommitTime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dead-code MSBuild tasks from
xa-prep-tasksandBootstrapTasksthat are no longer referenced anywhere in the build system.
xa-prep-tasks (12 removed):
AcceptAndroidSdkLicenses,CheckoutExternalGitDependency,CreateFilePaths,GitCommitTime,GitDiff,HashFileContents,NDKInfo,ParseExternalGitDependencies,PrepareInstall,RunParallelTargets,SetEnvironmentVariable,SystemUnzipBootstrapTasks (3 removed):
CreateFrameworkList,GenerateMonoDroidIncludes,GenerateProfileAlso removed stale
<UsingTask>declarations forGitCommitTime(
XAVersionInfo.targets) andGenerateProfile(
Xamarin.Android.Build.Tasks.targets).