Skip to content

Fix MSB4096 error with user-defined TrimmerRootAssembly items lacking RootMode metadata #10759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 5 commits into from
Feb 4, 2026
Merged

Fix MSB4096 error with user-defined TrimmerRootAssembly items lacking RootMode metadata #10759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8d4c0b1
Initial plan
Copilot Feb 3, 2026
ccb5918
Fix MSB4096 error with user-defined TrimmerRootAssembly items
Copilot Feb 3, 2026
a626b3a
Address code review feedback
Copilot Feb 3, 2026
5781c2e
Update src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Te…
jonathanpeppers Feb 4, 2026
dd90568
Update src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Te…
jonathanpeppers Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...in.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.ILLink.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ This file contains the .NET 5-specific targets to customize ILLink

<Target Name="_FixRootAssembly" AfterTargets="PrepareForILLink">
<ItemGroup>
<TrimmerRootAssembly Update="@(TrimmerRootAssembly)" Condition=" '%(RootMode)' == 'EntryPoint' " RootMode="All" />
<TrimmerRootAssembly Update="@(TrimmerRootAssembly)" Condition=" '%(TrimmerRootAssembly.RootMode)' == 'EntryPoint' " RootMode="All" />
</ItemGroup>
</Target>

Expand Down
17 changes: 17 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2299,5 +2299,22 @@ public CustomView (Context context) : base (context) { }
using var builder = CreateApkBuilder ();
Assert.IsTrue (builder.Build (proj), "Build should have succeeded.");
}

[Test]
public void TrimmerRootAssemblyWithoutRootMode ()
{
// Verifies that user-defined TrimmerRootAssembly items without RootMode metadata
// don't cause MSB4096 error in _FixRootAssembly target
var proj = new XamarinAndroidApplicationProject {
IsRelease = true,
};

// Add TrimmerRootAssembly items without RootMode metadata
proj.OtherBuildItems.Add (new BuildItem ("TrimmerRootAssembly", "Mono.Android"));
proj.OtherBuildItems.Add (new BuildItem ("TrimmerRootAssembly", "System.Runtime"));

using var builder = CreateApkBuilder ();
Assert.IsTrue (builder.Build (proj), "Build should have succeeded.");
}
}
}
Loading