Skip to content

[3.0] Fix OpenAL loading on Windows and make the examples run out-of-the-box#2573

Merged
Exanite merged 2 commits into
develop/3.0from
feature/examples-and-openal-loading
May 18, 2026
Merged

[3.0] Fix OpenAL loading on Windows and make the examples run out-of-the-box#2573
Exanite merged 2 commits into
develop/3.0from
feature/examples-and-openal-loading

Conversation

@Exanite
Copy link
Copy Markdown
Member

@Exanite Exanite commented Apr 30, 2026 •
edited
Loading

Summary of the PR

This will fix #2572

Related issues, Discord discussions, or proposals

Discord discussion: https://discord.com/channels/521092042781229087/587346162802229298/1499401418896048238

Further Comments

Should wait until #2570 is merged before merging this one.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026 •
edited
Loading

Some of the native library builds modified in this PR were not referenced in the PR description. Please ensure that the PR description contains /build-native OpenAL-Soft. These libraries won't be rebuilt without this being specified. If you believe this is in error, then please write a comment explaining why and ignore this suggestion. This comment will be automatically updated if rectified.

@Exanite Exanite mentioned this pull request Apr 30, 2026
Merged
14 tasks
@Exanite Exanite marked this pull request as ready for review April 30, 2026 17:18
@Exanite Exanite requested a review from a team as a code owner April 30, 2026 17:18
@Exanite Exanite marked this pull request as draft April 30, 2026 17:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026 •
edited
Loading

File Coverage
All files 16% ✅

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against eca14f9

@Exanite
Copy link
Copy Markdown
Member Author

Exanite commented Apr 30, 2026

Looks like the license identifier is invalid and causing the pack step of the build to fail:
image

Also, it looks like the correct identifier should be LGPL-2.0-or-later instead of v2.1.
image
image
image

@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Silk.NET Development Tracker May 1, 2026
@Exanite Exanite mentioned this pull request May 3, 2026
Open
@Exanite Exanite force-pushed the feature/examples-and-openal-loading branch from bb59721 to eca14f9 Compare May 18, 2026 10:00
@Exanite
Copy link
Copy Markdown
Member Author

Exanite commented May 18, 2026 •
edited
Loading

Force pushed to rebase the branch on develop/3.0.

Edit: Also looks like CLA fixes itself as soon as the CI bot commits are removed.

@Exanite Exanite marked this pull request as ready for review May 18, 2026 10:11
@Exanite Exanite merged commit 0080d4f into develop/3.0 May 18, 2026
18 checks passed
@Exanite Exanite deleted the feature/examples-and-openal-loading branch May 18, 2026 10:15
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Silk.NET Development Tracker May 18, 2026
@Exanite Exanite mentioned this pull request May 18, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curin curin curin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Silk.NET Development Tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Exanite @curin