Skip to content
This repository was archived by the owner on Aug 13, 2025. It is now read-only.

Conversation

@rconnett
Copy link

No description provided.

@RafaRuiz
Copy link
Contributor

RafaRuiz commented May 5, 2022

  • Does this require a change in the README?
  • Any breaking change? as the constants have been used
  • Could you please explain briefly why the change between localStorage.token to localStorage[AUTH_TOKEN]
    (or mainly why the change between localStorage.foo -> localStorage[BAR])

@rconnett
Copy link
Author

rconnett commented May 6, 2022

You shouldn't need to change the RADME.
I don't see a breaking change however Marwan indicated that it would cause problems for one of your clients so I've just been using our forked version since then.
The updates to the localStorage usage was to fix what was already there. Some of the code had been updated to use the constants for localStorage previously but the code I've updated had been left as not using the constants so those bits it just didn't work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants