MapObjBlock mostly matching#106
Merged
Merged
Conversation
Report for GMSJ01 (6e3c02c - 83151a4)📈 Matched code: 31.07% (+0.12%, +4252 bytes) ✅ 40 new matches
...and 10 more new matches 📈 9 improvements in unmatched items
|
Mrkol
reviewed
May 18, 2026
| class TSandBlock : public TMapObjBase { | ||
| public: | ||
| // Fabricated | ||
| typedef enum ESandBlockStates { |
Collaborator
There was a problem hiding this comment.
you don't need the typedef keyword here. Also, as these are enums and not enum classes, please prefer prefixing the names with the type of thing being described, and don't duplicate info that's already given in the parent scope. E.g. with your current code you'd have TSandBlock::Waiting for values and TSandBlock::ESandBlockStates for variable types, which is a bit weird. Instead, lets name the enum EState and the elements STATE_WAITING so that we have TSandBlock::EState state = TSandBlock::STATE_WAITING
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed gekko_ps_copy12 to match, but i'm not sure if there is any issues with the change or not. I can gladly revert it if wanted :)