Skip to content

MarioUpper initial pass.#105

Merged
Mrkol merged 5 commits into
doldecomp:mainfrom
CaptainProton42:MarioUpper
May 17, 2026
Merged

MarioUpper initial pass.#105
Mrkol merged 5 commits into
doldecomp:mainfrom
CaptainProton42:MarioUpper

Conversation

@CaptainProton42
Copy link
Copy Markdown
Contributor

Got all functions in this TU matching except some stack space and register usage.

I had to fabricate some inlines, especially to force the use of getCurrentNozzle const. Most of these are probably a bit dodgy.

@decomp-dev
Copy link
Copy Markdown

decomp-dev Bot commented May 17, 2026

Report for GMSJ01 (ae6ac08 - 7df9eb1)

📈 Matched code: 30.91% (+0.03%, +1044 bytes)
📈 Matched data: 39.63% (+0.03%, +204 bytes)

✅ 5 new matches
Unit Item Bytes Before After
mario/Player/MarioUpper __sinit_MarioUpper_cpp +764 0.00% 100.00%
mario/Player/MarioUpper TMario::checkPumping() +280 0.00% 100.00%
mario/Player/MarioUpper .bss +184 0.00% 100.00%
mario/Player/MarioUpper .sdata2 +16 0.00% 100.00%
mario/Player/MarioUpper .ctors +4 0.00% 100.00%
📈 2 improvements in unmatched items
Unit Item Bytes Before After
mario/Player/MarioUpper TMario::stateMachineUpper() +628 0.00% 99.42%
mario/Player/MarioUpper TMario::checkPumpEnable() +459 0.00% 99.93%

Comment thread include/M3DUtil/M3UModel.hpp Outdated
Comment thread include/Player/MarioAnimeData.hpp Outdated
Comment thread include/Player/MarioMain.hpp Outdated
@Mrkol Mrkol merged commit 6337448 into doldecomp:main May 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants