refactor: replace chan Event threading with EventSink interface#2760
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
rumpl
previously approved these changes
May 11, 2026
dgageot
force-pushed
the
runtime/event-sink-v2
branch
3 times, most recently
from
604519e to
54de93c
Compare
dgageot
force-pushed
the
runtime/event-sink-v2
branch
from
54de93c to
7556108
Compare
rumpl
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce an EventSink interface to replace the ~40
chan Eventparameters threaded through the runtime. KillschanSend, renameschanEmittertosinkEmitter, addsEventSinkFuncadapter for tests. External callers wrap channels withNewChannelSink(ch). Pure refactor, no behaviour change.