refactor: extract loopState struct to bundle runTurn parameters#2759
Merged
Conversation
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The refactor correctly bundles 15 mutable per-RunStream variables into a loopState struct. All field initialisations match their original zero/non-zero values, the struct is created fresh per RunStream call (no cross-call state bleed), pointer semantics for overflowCompactions are preserved, and the three-way slices.Concat ordering in runTurn is unchanged. No behavioural regressions found.
gtardif
approved these changes
May 11, 2026
rumpl
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle the 15 mutable per-RunStream variables into a single loopState struct. Only loop.go is modified. Pure refactor, no behaviour change.