Skip to content

Conversation

@ricardobranco777
Copy link
Contributor

@ricardobranco777 ricardobranco777 commented Jan 30, 2026

What I did

Fix pull failure assertion for Docker v29.2

The error message comes now from containerd.

Related issue

#13565

Otherwise test fails with:

=== RUN   TestComposePull/Verify_pull_failure
    pull_test.go:68: Running command: /usr/lib/docker/cli-plugins/docker-compose --project-directory fixtures/compose-pull/unknown-image pull
    pull_test.go:69: assertion failed: 
        Command:  /usr/lib/docker/cli-plugins/docker-compose --project-directory fixtures/compose-pull/unknown-image pull
        ExitCode: 1
        Error:    exit status 1
        Stdout:   
        Stderr:    Image does_not_exists Pulling 
         Image doesn_t_exists_either Pulling 
         Image alpine:3.15 Pulling 
         Image alpine:3.15 Pulled 
         Image doesn_t_exists_either failed to resolve reference "docker.io/library/doesn_t_exists_either:latest": docker.io/library/doesn_t_exists_either:latest: not found 
         Image does_not_exists Error failed to resolve reference "docker.io/library/does_not_exists:latest": docker.io/library/does_not_exists:latest: not found
        time="2026-01-30T08:23:20-05:00" level=warning msg="WARNING: Some service image(s) must be built from source by running:\n    docker compose build can_build"
        Error response from daemon: failed to resolve reference "docker.io/library/does_not_exists:latest": docker.io/library/does_not_exists:latest: not found
        
        
        Failures:
        Expected stderr to contain "pull access denied for does_not_exists"
    --- FAIL: TestComposePull/Verify_pull_failure (0.92s)
FAIL pkg/e2e.TestComposePull/Verify_pull_failure (0.92s)

The error message comes now from containerd.

Signed-off-by: Ricardo Branco <rbranco@suse.de>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have more context? Is it possible that SUSE is carrying patches? While docker changed to use containerd for image store as a default, I don't think the error changed;

From docker info;

 Server Version: 29.2.0
 Storage Driver: overlayfs
  driver-type: io.containerd.snapshotter.v1
...
 containerd:
  Version:          v2.2.1
  GitCommit:        dea7da592f5d1d2b7755e3a161be07f43fad8f75

Pulling a non-existing image;

docker pull doesn_t_exists_either
Using default tag: latest
Error response from daemon: pull access denied for doesn_t_exists_either, repository does not exist or may require 'docker login'

@ndeloof
Copy link
Contributor

ndeloof commented Feb 3, 2026

Our CI can run those tests with docker engine v29 without failure.
I'm fine we make the check more flexible, but would like to understand the root cause for this error message to differ in your context, so we can maybe make the test more deterministic

@thaJeztah
Copy link
Member

Yes, there's some related discussion happening on the moby PR (moby/moby#51972) as well.

At some point we may want to pass through some of those errors as-is, but we currently don't do so, so I'd like to get clear why tests are failing for @ricardobranco777 before making changes (in case there's a bug somewhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants