Skip to content

vendor: update buildkit to v0.30.0-rc1#3834

Merged
tonistiigi merged 1 commit intodocker:masterfrom
tonistiigi:buildkit-v0.30.0-rc1
May 6, 2026
Merged

vendor: update buildkit to v0.30.0-rc1#3834
tonistiigi merged 1 commit intodocker:masterfrom
tonistiigi:buildkit-v0.30.0-rc1

Conversation

@tonistiigi
Copy link
Copy Markdown
Member

No description provided.

Comment thread cmd/buildx/tracing.go
"go.opentelemetry.io/otel"

_ "github.com/moby/buildkit/util/tracing/env"
_ "github.com/moby/buildkit/util/tracing/childprocess"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsternberg please check this

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed Jaeger import as it was including some new big packages but not 100% this is compatible with old version atm.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the jaeger import you're mentioning here. This change from env to childprocess is correct though.

Copy link
Copy Markdown
Member Author

@tonistiigi tonistiigi May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I had a "github.com/moby/buildkit/util/tracing/detect/jaeger" import here as well but it caused ~25k lines worth of new packages to be imported.

@tonistiigi tonistiigi force-pushed the buildkit-v0.30.0-rc1 branch from f2d4bb9 to 94cac2c Compare May 6, 2026 21:18
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi force-pushed the buildkit-v0.30.0-rc1 branch from 94cac2c to a3147eb Compare May 6, 2026 22:07
@tonistiigi tonistiigi marked this pull request as ready for review May 6, 2026 22:07
@tonistiigi tonistiigi changed the title vendor: update buildkit to v0.30.0-rc1-dev vendor: update buildkit to v0.30.0-rc May 6, 2026
@tonistiigi tonistiigi changed the title vendor: update buildkit to v0.30.0-rc vendor: update buildkit to v0.30.0-rc1 May 6, 2026
@tonistiigi tonistiigi requested review from jsternberg and thaJeztah May 6, 2026 22:43
@tonistiigi tonistiigi merged commit 9392590 into docker:master May 6, 2026
160 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants