Skip to content

Comments

feat: add flags of ic-gateway to pocket-ic to disable the authority check and enable local file provider#8964

Open
shilingwang wants to merge 5 commits intomasterfrom
shiling/pocket-ic
Open

feat: add flags of ic-gateway to pocket-ic to disable the authority check and enable local file provider#8964
shilingwang wants to merge 5 commits intomasterfrom
shiling/pocket-ic

Conversation

@shilingwang
Copy link
Contributor

@shilingwang shilingwang commented Feb 20, 2026

#Node-1867

We recently added 2 new features in ic-gateway:

  1. A new custom domains provider: local file provider, which allows using a local file to provide the custom domains.
  2. Disable the authority check on validate middleware. We found the limitation when updating the pocketic version in the ic-gateway repo. It is not easy/very useful for testing environment to make the authority check especially pocketic always process the request from ic-gateway first regardless of where the request is from.

This PR introduced these 2 flags to pocket-ic.

@shilingwang shilingwang requested a review from mraszyk February 20, 2026 11:40
@shilingwang shilingwang changed the title feat:add flags of ic-gateway to pocket-ic to disable the authority check and enable local file provider feat: add flags of ic-gateway to pocket-ic to disable the authority check and enable local file provider Feb 20, 2026
@github-actions github-actions bot added the feat label Feb 20, 2026
@shilingwang shilingwang marked this pull request as ready for review February 20, 2026 16:11
@shilingwang shilingwang requested review from a team as code owners February 20, 2026 16:11
@shilingwang shilingwang requested a review from mraszyk February 20, 2026 16:11
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@shilingwang shilingwang dismissed github-actions[bot]’s stale review February 20, 2026 16:39

Only update the version of ic-gateway and the changes are only on pocketic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants