This repository was archived by the owner on Sep 4, 2021. It is now read-only.
Allow latitude and longitude as position properties#57
Open
pcfutures wants to merge 3 commits intodevfd:masterfrom
pcfutures:master
Open
Allow latitude and longitude as position properties#57pcfutures wants to merge 3 commits intodevfd:masterfrom pcfutures:master
latitude and longitude as position properties#57pcfutures wants to merge 3 commits intodevfd:masterfrom
pcfutures:master
Conversation
added 3 commits
August 25, 2017 14:38
Changes `Geocoder.geocodePosition()` to allow `latitude` and `longitude` as well as `lat` and `lng`.
Updates README.md to signify that `latitude` and `longitude` can be used.
`apiKey`, `position` and `address` don't need to be checked here as they're already checked before these functions are called!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Geocoder.geocodePosition() takes an object like:
this PR allows
latandlngto belatitudeorlongitudeinstead, respectively:Just a little nicety for users.
I realised this would be nice to have when using this package alongside
react-native-google-place-pickerwhich returnslatitudeandlongitudein it's response, allowing something like this: