Add button ,input and text area, Add register files and Login files#14
Open
SiansandaTamara wants to merge 12 commits intodevelopfrom
Open
Add button ,input and text area, Add register files and Login files#14SiansandaTamara wants to merge 12 commits intodevelopfrom
SiansandaTamara wants to merge 12 commits intodevelopfrom
Conversation
SiansandaTamara
requested review from
AbonyiXavier,
John-pels and
donkennie
and removed request for
AbonyiXavier and
donkennie
John-pels
reviewed
Nov 7, 2022
components/register.html
Outdated
Comment on lines
22
to
47
Contributor
There was a problem hiding this comment.
Why are you using react syntax for the attributes?
John-pels
reviewed
Nov 9, 2022
components/login.html
Outdated
Comment on lines
1
to
27
Contributor
There was a problem hiding this comment.
This is meant to be a component and not a whole web page
John-pels
reviewed
Nov 9, 2022
components/register.html
Outdated
Comment on lines
1
to
31
Contributor
There was a problem hiding this comment.
This is also meant to be a component and not a web page. Somebody has done the login page, you can check login.html and use the same layout for the register page.
John-pels
requested changes
Nov 9, 2022
Contributor
There was a problem hiding this comment.
The html files in the components folder shouldn't have HTML delimiters and head tag.
@John-pels you can check the latest changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following were implemented