Allow pixelnuke to be fullscreened on startup by commandline argument#22
Open
H3wastooshort wants to merge 6 commits intodefnull:masterfrom
Open
Allow pixelnuke to be fullscreened on startup by commandline argument#22H3wastooshort wants to merge 6 commits intodefnull:masterfrom
H3wastooshort wants to merge 6 commits intodefnull:masterfrom
Conversation
emdete
reviewed
Mar 11, 2024
There was a problem hiding this comment.
while the function contains a for-loop you return / exit the function inside a case. so multiple options are not processed.
furthermore you can use curly brackets to start a new block where you introduce new variables instead of using an empty statement. this is cleaner and it shows clearly the lifetime of that variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't worry i tested it.