code-test-mondrian modified#2
Open
olivier-encrypt wants to merge 2 commits intodeepspacerobots:mainfrom
Open
Conversation
Contributor
|
@olivier-encrypt Can you try to meet these 2 requirements from the instructions?
|
Author
|
Hi Andrew, so if I understand correctly it has to be 600px wide both above and below and assuming we just had 3 white colors I make sure I have the 3 white but grouped right? Implying I will have to change the color of some of the rectangles.
From: Andrew Hale ***@***.***>
Sent: Monday, February 19, 2024 2:45 PM
To: deepspacerobots/code-test-mondrian ***@***.***>
Cc: olivier-encrypt ***@***.***>; Author ***@***.***>
Subject: Re: [deepspacerobots/code-test-mondrian] code-test-mondrian modified (PR #2)
Can you try to meet these 2 requirements from the instructions?
* Above 600px wide, the composition should resemble the painting.
* Below 600px wide, the composition should be a single column of all the rectangles with all similar colors grouped together.
—
Reply to this email directly, view it on GitHub <#2 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANBAULOAWWCPYONPTBI5CY3YUO2URAVCNFSM6AAAAABDOV6Y2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGEZTOOJXGU> .
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Contributor
|
Sorry, I see where the miscommunication is.
Something like this:
|
Author
|
alright Andrew I think I understood what you mean so I'm gonna try to do that today and you will probably see that tomorrow. It's kind of challenging but I'll try my best. Thank you so much
Sent from my T-Mobile 5G Device
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Andrew Hale ***@***.***>
Sent: Monday, February 19, 2024 6:32:13 PM
To: deepspacerobots/code-test-mondrian ***@***.***>
Cc: olivier-encrypt ***@***.***>; Mention ***@***.***>
Subject: Re: [deepspacerobots/code-test-mondrian] code-test-mondrian modified (PR #2)
Sorry, I see where the miscommunication is.
At screen sizes wider than 600px, the composition should resemble the painting.
At screen sizes more narrow than 600px, the composition should be a single column of all the rectangles with all similar colors grouped together.
Something like this:
[Uploading Screen Recording 2024-02-19 at 7.23.49 PM.gif…]
—
Reply to this email directly, view it on GitHub<#2 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANBAULL7NIHVD3JJQRH6IXDYUPVI3AVCNFSM6AAAAABDOV6Y2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGMYTENZRGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
modified code for screen size above and below 600px
Author
|
Hi Andrew. I just applied some changes to the CSS code. you can go ahead
and look it up.
I was able to modify it according to screen size, but unfortunately for me,
grouping the colors was tougher than I expected.😅
thanks for you review
…On Mon, Feb 19, 2024 at 6:37 PM olivier towa ***@***.***> wrote:
alright Andrew I think I understood what you mean so I'm gonna try to do
that today and you will probably see that tomorrow. It's kind of
challenging but I'll try my best. Thank you so much
Sent from my T-Mobile 5G Device
Get Outlook for Android <https://aka.ms/AAb9ysg>
------------------------------
*From:* Andrew Hale ***@***.***>
*Sent:* Monday, February 19, 2024 6:32:13 PM
*To:* deepspacerobots/code-test-mondrian <
***@***.***>
*Cc:* olivier-encrypt ***@***.***>; Mention <
***@***.***>
*Subject:* Re: [deepspacerobots/code-test-mondrian] code-test-mondrian
modified (PR #2)
Sorry, I see where the miscommunication is.
*At screen sizes wider than 600px*, the composition should resemble the
painting.
*At screen sizes more narrow than 600px,* the composition should be a
single column of all the rectangles with all similar colors grouped
together.
Something like this:
[image: Uploading Screen Recording 2024-02-19 at 7.23.49 PM.gif…]
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANBAULL7NIHVD3JJQRH6IXDYUPVI3AVCNFSM6AAAAABDOV6Y2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGMYTENZRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes committed