docs(skills): add dpdata minimizer skill#955
docs(skills): add dpdata minimizer skill#955njzjz-bot wants to merge 2 commits intodeepmodeling:masterfrom
Conversation
📝 WalkthroughWalkthroughIntroduces a new documentation file for dpdata minimizer plugins, explaining the System.minimize API, supported minimizers (ase, sqm), driver requirements for ASEMinimizer, and providing a runnable ASE example with usage notes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
for more information, see https://pre-commit.ci
Merging this PR will improve performance by 17.31%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | test_import |
11.5 ms | 9.8 ms | +17.31% |
| ⚡ | WallTime | test_cli |
373.1 ms | 336.3 ms | +10.94% |
Comparing njzjz-bot:skills/dpdata-minimizer-skill (ec58a8c) with master (d68b700)
There was a problem hiding this comment.
🧹 Nitpick comments (1)
skills/dpdata-minimizer/SKILL.md (1)
66-66: Consider using context manager for file operations.The file handle is not explicitly closed. While Python will eventually close it, using a context manager is better practice for documentation examples.
♻️ Suggested improvement
-open("tmp.xyz", "w").write("""2\n\nH 0 0 0\nH 0 0 0.74\n""") +with open("tmp.xyz", "w") as f: + f.write("""2\n\nH 0 0 0\nH 0 0 0.74\n""")🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/dpdata-minimizer/SKILL.md` at line 66, The example opens a file without ensuring it is closed; replace the bare open("tmp.xyz", "w").write(...) pattern with a context manager so the file is reliably closed (use with open("tmp.xyz", "w") as f: f.write(...)). Update the SKILL.md example where the current open(...) call appears to use a direct .write to instead use the with-statement around the write operation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@skills/dpdata-minimizer/SKILL.md`:
- Line 66: The example opens a file without ensuring it is closed; replace the
bare open("tmp.xyz", "w").write(...) pattern with a context manager so the file
is reliably closed (use with open("tmp.xyz", "w") as f: f.write(...)). Update
the SKILL.md example where the current open(...) call appears to use a direct
.write to instead use the with-statement around the write operation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 36b60c7f-7540-4c7d-8bd1-76181dc27d2a
📒 Files selected for processing (1)
skills/dpdata-minimizer/SKILL.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #955 +/- ##
=======================================
Coverage 86.37% 86.37%
=======================================
Files 86 86
Lines 8086 8086
=======================================
Hits 6984 6984
Misses 1102 1102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a new Agent Skill document under skills/dpdata-minimizer/ that explains how to use dpdata's minimizer plugins and System.minimize() API, including the relationship between drivers and minimizers and a runnable ASE example.
Changes:
- Added
SKILL.mddocumenting dpdata minimizer plugin usage, supported minimizer keys, and the driver/minimizer relationship - Included a runnable ASE minimization example with uv inline script metadata
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This PR adds an Agent Skill under
skills/documenting dpdata minimizer plugins andSystem.minimize()usage.Includes a runnable ASE minimization example and clarifies the driver/minimizer relationship (ASEMinimizer expects a dpdata Driver, not a raw ASE calculator).
Authored by OpenClaw (model: gpt-5.2)
Summary by CodeRabbit