fix(cli): mute warnings during cobra command configuration#2204
Open
fix(cli): mute warnings during cobra command configuration#2204
Conversation
- Move home dir detection into RunE function. - Cleanup flags descriptions. - Build d8v in current dir, instead of a hidden directory. - More examples for ssh command. Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
Warnings from "virtualization" command affects other commands in d8 cli.
What is the expected result?
No warnings if $HOME is empty
Before:
After:
Clean descriptions for ssh/scp flags
Before:
After:
Notes about changes in deckhouse/deckhouse-cli
PR: deckhouse/deckhouse-cli#324
Virtualization module is already migrated to Go 1.25 in the 'main' branch. deckhouse-cli still uses Go 1.24. These changes are backported to release-1.6 in branch fix/cli/mute-warnings-during-cobra-init-release-1-6-2 so dependencies in go.mod are compatible with the current state of dependencies in deckhouse-cli.
Checklist
Changelog entries