Skip to content

chore(vmip): range #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eofff wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(vmip): range #2201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions images/virtualization-artifact/pkg/controller/vmip/vmip_webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,21 +65,19 @@ func (v *Validator) ValidateCreate(ctx context.Context, obj runtime.Object) (adm
return nil, fmt.Errorf("the VirtualMachineIPAddress validation is failed: %w", err)
}

var warnings admission.Warnings

if vmip.Spec.StaticIP != "" {
err = v.validateAllocatedIPAddresses(ctx, vmip.Spec.StaticIP)
switch {
case err == nil:
// OK.
case errors.Is(err, service.ErrIPAddressOutOfRange):
warnings = append(warnings, fmt.Sprintf("The requested address %s is out of the valid range", vmip.Spec.StaticIP))
return nil, fmt.Errorf("the requested address %s is out of the valid range", vmip.Spec.StaticIP)
default:
return nil, err
}
}

return warnings, nil
return nil, nil
}

func (v *Validator) ValidateUpdate(ctx context.Context, oldObj, newObj runtime.Object) (admission.Warnings, error) {
Expand Down
Loading