fix(dvcr): resume postponed imports after garbage collection#2193
Draft
fix(dvcr): resume postponed imports after garbage collection#2193
Conversation
These changes should fix problem when VI/CVI/VD stuck in "Postponed" state. Add a DVCR garbage collection secret watcher for VI, CVI, and VD controllers to requeue postponed resources when garbage collection is over. Add a timeout for the DVCR garbage collection in dvcr-gc controller. It should auto-heal Deploy/dvcr and postponed VI/CVI/VD in case dvcr-cleaner is failed. Minor: - Handle nil garbage collection secret in dvcr-cleaner when adding cleanup completion annotation. - Refactor dvcr gc secret watcher: filter events for secret early in predicate functions. Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
diafour
requested review from
LopatinDmitr,
danilrwx,
eofff,
hardcoretime and
loktev-d
eofff
requested changes
Apr 9, 2026
| } | ||
|
|
||
| if err := w.client.List(ctx, resList, &client.ListOptions{}); err != nil { | ||
| return nil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes should fix problem when VI/CVI/VD stuck in "Postponed" state.
Add a DVCR garbage collection secret watcher for VI, CVI, and VD controllers to requeue postponed resources when garbage collection is over.
Add a timeout for the DVCR garbage collection in dvcr-gc controller. It should auto-heal Deploy/dvcr and postponed VI/CVI/VD in case dvcr-cleaner is failed.
Minor:
Why do we need it, and what problem does it solve?
These changes should fix problem when VI/CVI/VD stuck in "Postponed" state.
DVCR is not in "garbage collection" state, result is in the secret, but VI still has Postponed condition.
What is the expected result?
CVI/VI/VD should proceed with importing after DVCR garbage collection is done.
Checklist
Changelog entries