fix(vmsnapshot): snapshotting vm without main network#2176
Open
fix(vmsnapshot): snapshotting vm without main network#2176
Conversation
eofff
force-pushed
the
fix/vmsnapshot/snapshotting-without-main-network
branch
from
03bf842 to
2d6681d
Compare
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
eofff
force-pushed
the
fix/vmsnapshot/snapshotting-without-main-network
branch
from
2d6681d to
96a570e
Compare
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
eofff
force-pushed
the
fix/vmsnapshot/snapshotting-without-main-network
branch
from
96a570e to
007b844
Compare
Contributor
|
Workflow has started. The target step completed with status: failure. |
Contributor
|
Workflow has started. The target step completed with status: failure. |
Contributor
LopatinDmitr
left a comment
LopatinDmitr
left a comment
There was a problem hiding this comment.
The PR is fixing the edge-case, but I haven't seen any tests on it.
images/virtualization-artifact/pkg/controller/service/restorer/snapshot_resources.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vmrestore/internal/life_cycle.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vmrestore/internal/life_cycle.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/restorer/snapshot_resources.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix snapshotting VM without Main network.
Checklist
Changelog entries