Skip to content

[deckhouse-cli] Add registry error diagnostics for d8 mirror #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Glitchy-Sheep wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[deckhouse-cli] Add registry error diagnostics for d8 mirror #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9516d1b
Add registry error diagnostics for d8 mirror pull/push
Glitchy-Sheep Apr 6, 2026
b898286
Refactor registry error diagnostics into layered architecture
Glitchy-Sheep Apr 10, 2026
da62565
Move validation package to internal/mirror
Glitchy-Sheep Apr 10, 2026
3442885
Remove demo script from diffs
Glitchy-Sheep Apr 10, 2026
953dd8a
Move error classifier to internal/mirror
Glitchy-Sheep Apr 10, 2026
e91f118
Split error diagnostics into per-command classifiers
Glitchy-Sheep Apr 10, 2026
afa0bf0
Update diagnostic docs to reflect per-command errdetect structure
Glitchy-Sheep Apr 10, 2026
094bc2f
Move errmatch to internal/mirror and align file naming
Glitchy-Sheep Apr 10, 2026
929733f
Unwrap error chain into indented tree in diagnostic output
Glitchy-Sheep Apr 12, 2026
c1066a5
Link each diagnostic cause with its specific solutions
Glitchy-Sheep Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion cmd/d8/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ import (
"github.com/deckhouse/deckhouse-cli/internal/tools"
useroperation "github.com/deckhouse/deckhouse-cli/internal/useroperation/cmd"
"github.com/deckhouse/deckhouse-cli/internal/version"
"github.com/deckhouse/deckhouse-cli/pkg/diagnostic"
)

type RootCommand struct {
Expand Down Expand Up @@ -174,7 +175,15 @@ func (r *RootCommand) Execute() error {
func execute() {
rootCmd := NewRootCommand()
if err := rootCmd.Execute(); err != nil {
fmt.Fprintf(os.Stderr, "Error executing command: %v\n", err)
// If a command returned a HelpfulError, show formatted diagnostic.
// Commands are responsible for classifying their own errors using
// domain-specific errdetect packages (e.g. errdetect.Diagnose for mirror).
var helpErr *diagnostic.HelpfulError
if errors.As(err, &helpErr) {
fmt.Fprint(os.Stderr, helpErr.Format())
} else {
fmt.Fprintf(os.Stderr, "Error executing command: %v\n", err)
}
os.Exit(1)
}
}
Loading
Loading