Open
Conversation
- Prefer usage of postgres vs pg - Ping the image to supported postgres version - Fix the environment variables so we don't need to use 'trust' - Hardcode the postgres DB password (this is just a demo) - Add healthcheck - Add explicit depenency between decidim and postgres
📝 WalkthroughWalkthroughThe Docker Compose configuration is updated to replace the PostgreSQL service definition, renaming the top-level key from "version" to "name," adding service health checks, updating the database hostname from "pg" to "postgres," and introducing new environment variables for database credentials and password management. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to provide quick instructions to someone for using a demo of Decidim, but when I checked the docker-compose locally I noticed that it didn't work out-of-the-box with the instructions that we have in the README of this repository. This PR fixes it.
Testing
Same instructions that we have in the README
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.