Open
Conversation
`CodableSupport` is a trait that's by default enabled.
The Codable related APIs are enabled by this trait.
When this trait is not enabled, the lower level parsing API remain
available, and that portion must not depend on Foundation.
All the stand test should pass for non-`CodableSupport` potion of the library.
The non-`CodableSupport` APIs should function for embedded Swift.
Few things needs to happen before this gets merged:
- [ ] A reliable CI check for running tests without the default trait
- [ ] A CI build for embedded Swift of the non-`CodableSupport` part
- [ ] Documentation updates:
- [ ] A mention of embedded support in introductory materials
- [ ] An explanation of the trait
- [ ] Per API annotation about availability for embeded (or trait membership?)
- [ ] A dedicated article for embeded.
- [ ] An test on an actual embeded device :)
Closes #232
Closes #227
Comparing results between 'main' and 'pull_request'TOMLDecoderBenchmarksDecode toml.io example metricsTime (wall clock): results within specified thresholds, fold down for details.
Retains: results within specified thresholds, fold down for details.
Parse toml.io example metricsTime (wall clock): results within specified thresholds, fold down for details.
Retains: results within specified thresholds, fold down for details.
decode canada.toml metricsTime (wall clock): results within specified thresholds, fold down for details.
Retains: results within specified thresholds, fold down for details.
decode twitter.toml metricsTime (wall clock): results within specified thresholds, fold down for details.
Retains: results within specified thresholds, fold down for details.
parse GitHub events archive metricsTime (wall clock): results within specified thresholds, fold down for details.
Retains: results within specified thresholds, fold down for details.
parse canada.toml metricsTime (wall clock): results within specified thresholds, fold down for details.
Retains: results within specified thresholds, fold down for details.
parse twitter.toml metricsTime (wall clock): results within specified thresholds, fold down for details.
Retains: results within specified thresholds, fold down for details.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodableSupportis a trait that's by default enabled. The Codable related APIs are enabled by this trait. When this trait is not enabled, the lower level parsing API remain available, and that portion must not depend on Foundation. All the stand test should pass for non-CodableSupportpotion of the library. The non-CodableSupportAPIs should function for embedded Swift.Few things needs to happen before this gets merged:
CodableSupportpartCloses #232
Closes #227