-
Notifications
You must be signed in to change notification settings - Fork 680
Show user in password prompt (fixing regression) #1495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I removed it on purpose because when prompting the user for a password at the start, the username is not yet known unless the Line 507 in a237ee9
|
|
I see. We don't have |
cd5ca0b to
e77def3
Compare
In order to do this, we have to lose some special DSN logic. There is just no way under the current setup, since for instance the SSL params get parsed out of the DSN before calling connect(). Once solution could be to do all configuration parsing early, a long- term goal. Here we replace the DSN fallthrough with a warning message. The password_from_file logic is incidentally improved.
e77def3 to
5a07d42
Compare
|
@rolandwalker Apologies for the back and forth on this. After working for a while to try and re-add the original password related functionality back into your change (while keeping the user in the prompt), I realized it could be done in a much simpler way (as far as I can tell anyway). I created a new PR with what I believe works, and included your updated password file logic. I believe that was the only other thing that you added (other than the import re-organization, I added that as well). But if I missed something let me know: |
|
Closing in favor of #1502 . |
Description
It would seem that there was a regression in #1436, and we need to redo #1291.
In order to do this, we have to lose some special DSN logic. There is just no way under the current setup, since for instance the SSL params get parsed out of the DSN before calling
connect().Once solution could be to do all configuration parsing early, a long-term goal.
Here we replace the DSN fallthrough with a warning message.
The
password_from_filelogic is incidentally improved.Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.