Skip to content

fix: check is_available() before creating Spout/unavailable sinks and sources (#688) #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
livepeer-tessa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: check is_available() before creating Spout/unavailable sinks and sources (#688) #690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/scope/server/frame_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,12 @@ def _update_output_sink(
if sink_class is None:
logger.error(f"Unknown output sink type: {sink_type}")
return
if not sink_class.is_available():
logger.warning(
"Output sink '%s' is not available on this platform, skipping",
sink_type,
)
return
try:
sink = sink_class()
if sink.create(sink_name, width, height):
Expand Down Expand Up @@ -825,8 +831,9 @@ def _create_and_connect_input_source(self, source_type: str, source_name: str):
return

if not source_class.is_available():
logger.error(
f"Input source '{source_type}' is not available on this platform"
logger.warning(
"Input source '%s' is not available on this platform, skipping",
source_type,
)
return

Expand Down
Loading