Update Pybind11 to v2.12.0 for numpy v2 support (with submodule)#2971
Closed
yuzawa-san wants to merge 0 commit intodavisking:masterfrom
Closed
Update Pybind11 to v2.12.0 for numpy v2 support (with submodule)#2971yuzawa-san wants to merge 0 commit intodavisking:masterfrom
yuzawa-san wants to merge 0 commit intodavisking:masterfrom
Conversation
yuzawa-san
force-pushed
the
pybind-submodule
branch
from
bab0b50 to
6233808
Compare
Owner
|
Thanks for doing this too. I merged your other PR instead since I know a decent number of users get thrown off by git submodules. Although personally I use them and think they are fine. 🤷 But it's one less hurdle for users to jump though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
same as #2970 but with git submodule