fix: read converged overlap matrix for SC groups #1
Open
laraujo-1 wants to merge 1 commit into
Open
Conversation
Refactor getLine function to handle last occurrence search.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was happening
I was getting a persistent problem where the interference density plots were showing only positive values for the π-space of aromatic systems, which is physically nonsense. I tested this with a simple SC(6) calculation for benzene (no guess) and confirmed the issue: plotting the π interference density at 0.3 Å above the molecular plane gave an entirely positive map.
What I found
The bug is in
parse_overlaps. It turns out that for SC/GVB groups, VB2000 prints the overlap matrix twice in the output file, once before the orbital optimization starts (the initial LMO overlaps) and then after convergence (the final SC overlaps). The code was always grabbing the first one.The problem is that the density matrix in the
.dmatrixfile is computed from the converged orbitals, so using the pre-optimization overlaps breaks the QC/INT density partition. The initial overlaps are all positive, which is why the interference density was coming out wrong.Proposed fix
Two small changes:
core/parse_input.py— added support forpos=-1ingetLineto retrieve thelast occurrence of a string instead of the first:
core/parse_vb.py: added one extra argument to always read the converged matrix: