Initial metric support in sample ingest
#440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a sample metrics system for the
Roasterysample used byseqcli sample ingest. At the moment it supports an exponential histogram calledhttp.request.duration. I haven't used theSystem.Diagnostics.Metricsinfrastructure here because we simulate many HTTP servers in a single process, and didn't want to mess with any shared state. It's also just a very simple system as a starting point for future exploration.We'll want to take a look at the data model for histograms, property casing and naming, metric naming, and other things.
I haven't invested in test infrastructure yet, because support in Seq itself is still experimental and subject to change.