feat: Appkit cli commands #4247
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarioCadenas
force-pushed
the
appkit-cli-commands
branch
3 times, most recently
from
04f4c88 to
6e23dec
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 6760cdf
30 interesting tests: 22 KNOWN, 6 flaky, 1 SKIP, 1 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
fjakobs
requested changes
Jan 14, 2026
experimental/apps-mcp/templates/appkit/generic/client/index.html
Outdated
Show resolved
Hide resolved
experimental/apps-mcp/templates/appkit/generic/databricks.yml.tmpl
Outdated
Show resolved
Hide resolved
experimental/dev/cmd/app/prompt.go
Outdated
| @@ -0,0 +1,419 @@ | |||
| package app | |||
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
force-pushed
the
appkit-cli-commands
branch
from
d552cd0 to
f0b22d5
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
force-pushed
the
appkit-cli-commands
branch
from
9cbff3d to
38cc5a4
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
force-pushed
the
appkit-cli-commands
branch
from
748d4c1 to
bc617fb
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
force-pushed
the
appkit-cli-commands
branch
from
bc617fb to
26f3f28
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
force-pushed
the
appkit-cli-commands
branch
from
26f3f28 to
037121a
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
force-pushed
the
appkit-cli-commands
branch
from
037121a to
9ca1219
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
requested review from
a team,
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
fjakobs
approved these changes
Jan 16, 2026
pietern
requested changes
Jan 16, 2026
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
Blocking merging. Need to discuss the deps first.
arsenyinfo
requested changes
Jan 16, 2026
Contributor
arsenyinfo
left a comment
arsenyinfo
left a comment
There was a problem hiding this comment.
Those changes duplicate existing entities like template, validation etc and are not in sync with agentic prompts atm. We can't merge it unless there is a unification plan.
Contributor
|
This PR largely duplicates cli aitools already implemented http://github.com/databricks/cli/tree/main/experimental/aitools Also https://github.com/databricks/appkit/pull/57/changes template - another duplication https://github.com/databricks/cli/tree/main/experimental/aitools/templates/appkit |
Contributor
Author
the idea is to unify yes, but this comes with the approach of having this as humans first, through the apps scope, but of course, many of this should be used by the ai tools |
Contributor
Author
It has some similar things yes, I already mentioned this, we were doing similar things and we needed to converge into one. Let's talk about it in the sync |
Contributor
|
@arsenyinfo @keugenek this indeed duplicates functionality from We keep the existing tools under |
MarioCadenas
force-pushed
the
appkit-cli-commands
branch
from
7eb0a86 to
f277573
Compare
chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: validate command chore: fixup chore: remove import command chore: fixup
MarioCadenas
force-pushed
the
appkit-cli-commands
branch
from
f277573 to
ef5a6c6
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
|
It would be nice to make |
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Jan 19, 2026
| return fmt.Errorf("failed to run app: %w. Run `databricks apps logs %s` to view logs", err, appName) | ||
| } | ||
|
|
||
| cmdio.LogString(ctx, "✔ Deployment complete!") |
Contributor
There was a problem hiding this comment.
@andrewnester We'll need to update this after adding a "started" state to apps.
| } else { | ||
| log.Debugf(ctx, "No validator found for project type, skipping validation") | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
What kind of validation happens here that doesn't happen in the regular "bundle deploy"?
We need to be careful not to make this a hard prereq for deployment.
Contributor
Author
There was a problem hiding this comment.
No, this is actually to make things better, it runs validation of the app by running linting, typechecking, and building, so it verifies that everything works and the app won't fail to deploy once its running the building process inside the apps process.
Its basically to avoid the annoying behaviour of having to go into databricks or check the logs command to see why the app failed to deploy.
Right now we just have 1 validator for node apps, at some point we will probably have one for python apps too.
But if it doesn't find a validator, then it just keeps going (to avoid introducing breaking changes)
libs/apps/prompt/prompt.go
Outdated
|
|
||
| // printAnswered is an alias for internal use. | ||
| func printAnswered(title, value string) { | ||
| PrintAnswered(title, value) |
Contributor
There was a problem hiding this comment.
Print where? This should use cobra's stdout or stderr from the context or directly.
libs/apps/validation/nodejs.go
Outdated
|
|
||
| // runValidationCommand executes a shell command in the specified directory. | ||
| func runValidationCommand(ctx context.Context, workDir, command string) *ValidationDetail { | ||
| cmd := exec.CommandContext(ctx, "sh", "-c", command) |
Contributor
There was a problem hiding this comment.
Doesn't work on Windows. Check out libs/exec for something that'll use cmd.exe if needed.
go.mod
Outdated
| require ( | ||
| github.com/charmbracelet/huh v0.8.0 | ||
| github.com/charmbracelet/lipgloss v1.1.0 | ||
| ) |
Contributor
There was a problem hiding this comment.
Please fold into the main list above and include the license as a suffix comment.
Also please include in the NOTICE file.
Contributor
There was a problem hiding this comment.
What is the resulting binary size with/without these deps?
Contributor
Author
There was a problem hiding this comment.
Before:
After:
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Overview
This PR adds new AppKit development commands to
databricks apps, making them first-class citizens alongside the auto-generated Apps API commands. The implementation follows the same pattern established by thepipelinescommands.New Command Structure
databricks appsnow has three command groups:deploy,dev-remote,init,logs,run-local,validatecreate,delete,get,list,start,stop, etc.get-permissions,set-permissions, etc.Key Features
databricks apps init- Initialize new AppKit projects from templates with interactive prompts, but also allowing full prompt override via flags.databricks apps dev-remote- Run local Vite dev server with WebSocket bridge to remote app (this command already exists, but now has some improvements like deriving the project from the folder and reconnecting).databricks apps validate- Run validation of the app running type checking, linting and building.databricks apps deploy- Dual-mode deployment:Directory Structure
Why
Tests