[RHCLOUD-42870] Nx tool migration by Jakub007d · Pull Request #1518 · data-driven-forms/react-forms

Jakub007d · 2025-10-29T12:11:43Z

Fixes #(issue) (if applicable)

Description
As a part of the RHCLOUD-42870 task i have added the nx tool to help with running tests/linters/builds/type-checks/releases/publish in CI. Release and publish would be ran after the PR gets merged (For proper release/publish we need to add 2 secrets to the repository (NOT TESTED only the dry run was ran so far)).

Please include a summary of the change.

Updated Gitignore files
Added nx.json file which configure the nx tool
Added project.json to packages which defines which jobs are run on which packages

Schema (if applicable)

Checklist: (please see documentation page for more information)

Yarn build passes
Yarn lint passes
Yarn test passes
Test coverage for new code (if applicable)
Documentation update (if applicable)
Correct commit message
- format fix|feat({scope}): {description}
- i.e. fix(pf3): wizard correctly handles next button
- fix will release a new _._.X version
- feat will release a new _.X._ version (use when you introduce new features)
  - we want to avoid any breaking changes, please contact us, if there is no way how to avoid them
- scope: package
- if you update the documentation or tests, do not use this format
  - i.e. Fix button on documenation example page

vercel · 2025-10-29T12:11:50Z

@Jakub007d is attempting to deploy a commit to the data-driven-forms Team on Vercel.

A member of the Team first needs to authorize it.

codecov · 2025-10-29T12:25:07Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.28%. Comparing base (1fb351e) to head (77b6fb9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1518   +/-   ##
=======================================
  Coverage   94.28%   94.28%           
=======================================
  Files         185      185           
  Lines        3397     3397           
  Branches     1461     1461           
=======================================
  Hits         3203     3203           
  Misses        194      194

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…icit dependencies

florkbr · 2025-10-31T06:12:40Z

package.json

    "@khala/npm-release-monorepo": "^2.5.2",
    "@khala/wildcard-release-notes": "^2.5.2",
+    "@nx/js": "22.0.1",
    "@semantic-release/exec": "^6.0.3",


@Jakub007d since we are switching to NX's release process, I think we can remove the legacy semantic-release packages right?

You are right removed

florkbr · 2025-10-31T06:16:23Z

.github/workflows/main.yml

+        run: npx nx release --first-release --dry-run --verbose
+
+  # Job that runs after merge (on push to master)
+  post-merge:


@Jakub007d I'm wondering if we want the PR checks to also run for merge jobs, and just exclude the release for PRs. Something like we do here: https://github.com/RedHatInsights/javascript-clients/blob/main/.github/workflows/ci.yml

florkbr · 2025-10-31T06:17:45Z

package.json

    "lerna": "^4.0.0",
    "ncp": "^2.0.0",
-    "sass": "^1.77.8",
+    "nx": "^22.0.1",


NIT - looks like in the past 2 days NX released 22.0.2 😂

Oh :D updated

florkbr · 2025-10-31T06:26:31Z

@Jakub007d since we are moving to NX, should we remove Lerna as well and replace with NX? https://github.com/data-driven-forms/react-forms/blob/master/lerna.json

florkbr · 2025-10-31T06:30:41Z

nx.json

+      "fallbackCurrentVersionResolver": "disk"
+    }
+  },
+  "namedInputs": {


@Jakub007d quick AI review comment:

Your nx.json sets namedInputs.default to only sharedGlobals. For run-commands with cache=true this can cause stale cache. Suggest: In nx.json: Set namedInputs.default to include project sources, e.g. ["sharedGlobals", "{projectRoot}/**/*", "!{projectRoot}/dist/**", "!{projectRoot}/.next/**"]. Optionally add a production namedInput variant if needed. Or, per target in project.json, define inputs: ["default", "^default"].

Jakub007d · 2025-10-31T13:31:31Z

Hmm the tests for the react-form-renderer started failing im looking into it

Jakub007d · 2025-10-31T14:27:15Z

Fixed the failing test

JetyAdam

Running npx nx graph fails with a MultipleProjectsWithSameNameError. This is because many sub-projects (e.g., .../ant-component-mapper/checkbox and .../mui-component-mapper/checkbox) are being detected with the same name ("checkbox").

This error breaks the Nx dependency graph, which means core features like nx affected will not work.

JetyAdam

I've reviewed the latest commit, and this new approach of generating project.json files during the build unfortunately won't solve the problem.
Nx needs to read all project.json files before it can run any task, including the build task itself.

The MultipleProjectsWithSameNameError happens during this initial configuration scan, so Nx fails long before it ever gets a chance to run your new generate-sub-projects.js script.

These project.json files must be static configuration, not build artifacts.

The script you wrote is correct, but it needs to be used differently. Please run that script locally one time to generate all the project.json files, commit those new files directly to this PR, and then remove the build:sub-projects step from the package.json files.

This reverts commit 5ecbdd8.

… packages

JetyAdam

LGTM

Hyperkid123

A few more steps are remaining

make sure correct tags are on the git repository
remove the first-release flags
ensure NX publish root directories are configured to the packages/ dir (by default it expects assets to be at dist//)
verify the version is updating the correct files

Once these are done, we can update the secrets and publish

Jakub007d added 2 commits October 29, 2025 12:42

chore: adding Nx workspace configuration

b0f58be

ci: adding Github Actions to run tests/build/linters using NX

3919997

fix: installing nx for project

1d2408e

Jakub007d force-pushed the nx-tool-migration branch from 3707bc0 to 1d2408e Compare October 29, 2025 12:18

Jakub007d added 5 commits October 29, 2025 13:26

fix: CI fix

3435b1e

fix: nx.json config

b88a661

fix: CI fix

ec9b4ed

fix: using yarn build instead of rollup

d7e9daf

fix: removing uneeded typecheck from parser and removing uneeded impl…

8a2f1d9

…icit dependencies

Jakub007d force-pushed the nx-tool-migration branch from caa6f4a to 2c284a9 Compare October 29, 2025 15:15

fix: making nx release run

62ad341

Jakub007d force-pushed the nx-tool-migration branch 2 times, most recently from de61b39 to a484371 Compare October 29, 2025 16:23

ci: adding --first-release tag

23e49e8

Jakub007d force-pushed the nx-tool-migration branch from a484371 to 23e49e8 Compare October 29, 2025 16:36

fix: empty commit

9186926

florkbr reviewed Oct 31, 2025

View reviewed changes

Jakub007d added 2 commits October 31, 2025 13:30

ci: Running CI checks also on push

3ce4078

feat: removing lerna and semantic-release

06e8e80

Jakub007d force-pushed the nx-tool-migration branch from 5f2166a to 06e8e80 Compare October 31, 2025 13:02

fix: fixing failing test in form renderer

3cfa84f

Jakub007d force-pushed the nx-tool-migration branch from 707446d to 3cfa84f Compare October 31, 2025 13:55

Jakub007d requested a review from florkbr October 31, 2025 14:27

JetyAdam suggested changes Nov 4, 2025

View reviewed changes

Adding script for project.json generation for sub-packages

5ecbdd8

JetyAdam suggested changes Nov 6, 2025

View reviewed changes

Jakub007d added 2 commits November 7, 2025 15:08

Revert "Adding script for project.json generation for sub-packages"

cee450b

This reverts commit 5ecbdd8.

adding .nxignore files so the nx would not be confused with generated…

7f14cf1

… packages

JetyAdam approved these changes Nov 11, 2025

View reviewed changes

Hyperkid123 reviewed Nov 12, 2025

View reviewed changes

making sure that nx publish the build files in the package directory

51989be

Jakub007d force-pushed the nx-tool-migration branch from d2e231e to 51989be Compare November 17, 2025 13:51

Jakub007d and others added 2 commits November 18, 2025 11:52

resolving conflicts

77b6fb9

allow npm trusted publishing

e32d298

Hyperkid123 merged commit 2a5434e into data-driven-forms:master Nov 19, 2025
3 of 4 checks passed

Conversation

Jakub007d commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Oct 29, 2025

Uh oh!

codecov bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

florkbr commented Oct 31, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jakub007d commented Oct 31, 2025

Uh oh!

Jakub007d commented Oct 31, 2025

Uh oh!

JetyAdam left a comment

Choose a reason for hiding this comment

Uh oh!

JetyAdam left a comment

Choose a reason for hiding this comment

Uh oh!

JetyAdam left a comment

Choose a reason for hiding this comment

Uh oh!

Hyperkid123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Jakub007d commented Oct 29, 2025 •

edited

Loading

codecov bot commented Oct 29, 2025 •

edited

Loading