Skip to content

Conversation

@xdustinface
Copy link
Collaborator

@xdustinface xdustinface commented Jan 23, 2026

Merge master into dev branch.

Summary by CodeRabbit

  • Chores
    • Released patch version 0.41.1 with bincode serialization dependency upgraded to stable 2.0.1 (from pre-release 2.0.0-rc.3). This transition from pre-release to stable improves reliability and production readiness for data serialization and deserialization operations. Internal compatibility updates have been applied to support the new stable API while maintaining existing functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

lklimek and others added 3 commits January 15, 2026 12:14
* build(deps): bump bincode to 2.0.1

* Update dash-network/Cargo.toml

Co-authored-by: Kevin Rombach <35775977+xdustinface@users.noreply.github.com>

* chore(dash-spv): replace bincode 1.3.3 with bincode 2.0.1

---------

Co-authored-by: Kevin Rombach <35775977+xdustinface@users.noreply.github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

Version bump from 0.41.0 to 0.41.1 with upgrade of bincode dependency from 2.0.0-rc.3 to stable 2.0.1. API migrations applied across multiple crates to accommodate bincode 2.0.1's generic Context parameter for Decode/BorrowDecode traits.

Changes

Cohort / File(s) Summary
Documentation & Changelog
CHANGELOG.md, dash-network/README.md, dash-spv/ARCHITECTURE.md, dash-spv/CODE_ANALYSIS_SUMMARY.md, key-wallet-ffi/IMPORT_WALLET_FFI.md
Version references updated from 0.41.0 to 0.41.1; release notes added for bincode upgrade.
Workspace & Package Manifests
Cargo.toml, dash-network/Cargo.toml, dash/Cargo.toml, dash-spv/Cargo.toml, hashes/Cargo.toml, key-wallet/Cargo.toml, key-wallet-manager/Cargo.toml, rpc-json/Cargo.toml
Bincode dependency bumped from 2.0.0-rc.3 to 2.0.1 across all crates; workspace version incremented to 0.41.1.
Serialization API Migration
dash-network/src/chain/chainlock_manager.rs
Bincode serialization calls updated from deprecated bincode::serialize/bincode::deserialize to bincode::encode_to_vec(..., bincode::config::standard()) and bincode::decode_from_slice::<_, _>(..., bincode::config::standard()) with tuple unpacking.
Bincode Macro Implementations
hashes/src/bincode_macros.rs, hashes/src/internal_macros.rs
Macro-generated Decode and BorrowDecode trait implementations updated to generic Context parameter; Decoder/BorrowDecoder trait bounds now require Context = C.
Manual Trait Implementations - Hash Types
dash/src/address.rs, key-wallet/src/bip32.rs, key-wallet/src/derivation_bls_bip32.rs, key-wallet/src/derivation_slip10.rs, key-wallet/src/mnemonic.rs, key-wallet/src/wallet/root_extended_keys.rs
All Decode and BorrowDecode implementations generalized with Context parameter C; decoder trait bounds updated to Decoder<Context = C> and BorrowDecoder<'de, Context = C>; internal calls updated to explicit generic syntax where applicable.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~35 minutes

Poem

🐰 A hop, skip, and version jump—
From rc.3 to stable 2.0.1 we thump!
Context parameters now flow through the code,
Bincode's new API lights the encoding road.
Whiskers twitch with upgrade cheer! 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 7.69% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary action: merging a hotfix release (v0.41.1) into the dev branch (0.42-dev), which aligns with the changeset's version bump and release preparation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@key-wallet-ffi/IMPORT_WALLET_FFI.md`:
- Line 87: Update the line that says "The wallet bytes must be in bincode format
(version 2.0)" to explicitly reference the actual crate version "bincode 2.0.1"
and add a short compatibility note that wallets serialized with pre-release
"2.0.0-rc.3" may generally deserialize under 2.0.1 when using the same bincode
config but pre-releases are not guaranteed compatible; instruct consumers to
test deserialization of existing wallets and, if issues arise, reserialize
wallets with bincode 2.0.1 (include the bincode config used) or provide a
migration tool/script to reserialize from rc.3 to 2.0.1.
🧹 Nitpick comments (1)
dash-spv/CODE_ANALYSIS_SUMMARY.md (1)

3-5: Consider updating the analysis date to match the version bump.
The "Date" still reads 2025-01-21 while the codebase version is now 0.41.1; updating it would avoid confusion for readers.

@xdustinface xdustinface merged commit 27af496 into v0.42-dev Jan 24, 2026
53 checks passed
@xdustinface xdustinface deleted the chore/merge-0.41.1 branch January 24, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants