-
Notifications
You must be signed in to change notification settings - Fork 9
chore: merge hotfix v0.41.1 into 0.42-dev
#384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* build(deps): bump bincode to 2.0.1 * Update dash-network/Cargo.toml Co-authored-by: Kevin Rombach <35775977+xdustinface@users.noreply.github.com> * chore(dash-spv): replace bincode 1.3.3 with bincode 2.0.1 --------- Co-authored-by: Kevin Rombach <35775977+xdustinface@users.noreply.github.com>
📝 WalkthroughWalkthroughVersion bump from 0.41.0 to 0.41.1 with upgrade of bincode dependency from 2.0.0-rc.3 to stable 2.0.1. API migrations applied across multiple crates to accommodate bincode 2.0.1's generic Context parameter for Decode/BorrowDecode traits. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~35 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@key-wallet-ffi/IMPORT_WALLET_FFI.md`:
- Line 87: Update the line that says "The wallet bytes must be in bincode format
(version 2.0)" to explicitly reference the actual crate version "bincode 2.0.1"
and add a short compatibility note that wallets serialized with pre-release
"2.0.0-rc.3" may generally deserialize under 2.0.1 when using the same bincode
config but pre-releases are not guaranteed compatible; instruct consumers to
test deserialization of existing wallets and, if issues arise, reserialize
wallets with bincode 2.0.1 (include the bincode config used) or provide a
migration tool/script to reserialize from rc.3 to 2.0.1.
🧹 Nitpick comments (1)
dash-spv/CODE_ANALYSIS_SUMMARY.md (1)
3-5: Consider updating the analysis date to match the version bump.
The "Date" still reads 2025-01-21 while the codebase version is now 0.41.1; updating it would avoid confusion for readers.
Merge master into dev branch.
Summary by CodeRabbit
bincodeserialization dependency upgraded to stable 2.0.1 (from pre-release 2.0.0-rc.3). This transition from pre-release to stable improves reliability and production readiness for data serialization and deserialization operations. Internal compatibility updates have been applied to support the new stable API while maintaining existing functionality.✏️ Tip: You can customize this high-level summary in your review settings.