Skip to content

Use image proxy when serving dartdoc#9306

Merged
sigurdm merged 5 commits intodart-lang:masterfrom
sigurdm:image_proxy_dartdoc
Mar 23, 2026
Merged

Use image proxy when serving dartdoc#9306
sigurdm merged 5 commits intodart-lang:masterfrom
sigurdm:image_proxy_dartdoc

Conversation

@sigurdm
Copy link
Copy Markdown
Contributor

@sigurdm sigurdm commented Mar 20, 2026

Using a marker in the text to avoid us reparsing when serving.

Ideally we would do the sanitization (again) when serving, but we need to investigate the slowdown involved.

@sigurdm sigurdm requested review from isoos and jonasfj and removed request for isoos March 20, 2026 12:50
Comment thread pkg/_pub_shared/lib/dartdoc/dartdoc_page.dart Outdated
Comment thread pkg/_pub_shared/lib/dartdoc/dartdoc_page.dart Outdated
Comment thread app/lib/dartdoc/dartdoc_page.dart Outdated
@sigurdm sigurdm requested a review from jonasfj March 23, 2026 11:12
@sigurdm sigurdm merged commit 9a4dfe6 into dart-lang:master Mar 23, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants