Closed
Conversation
This version upgrade libsecp to latest. Fixes #39.
This was referenced Jan 23, 2024
Closed
10 tasks
vcunat
reviewed
Mar 20, 2024
| @@ -1,2 +1,2 @@ | |||
| coincurve>=15.0,<19 | |||
| coincurve>=15.0,<=19 | |||
There was a problem hiding this comment.
coincurve<=19,>=15.0 not satisfied by version 19.0.1
I guess you meant <20 instead of <=19?
There was a problem hiding this comment.
I don't get what you mean. 19.0.0 is marked as yanked. I was mentioning 19.0.1 which is not.
https://pypi.org/project/coincurve/#history
|
#41 needs to be addressed first |
prusnak
suggested changes
Jul 18, 2024
prusnak
left a comment
prusnak
left a comment
There was a problem hiding this comment.
coincurve 20 is out, can we update the PR to read coincurve>=15.0,<21 and release a new version please?
| @@ -1,9 +1,12 @@ | |||
| # 3.5 | |||
|
|
|||
| - Support Coincurve up to version 19. This version supports the latest libsecp. | |||
There was a problem hiding this comment.
Suggested change
| - Support Coincurve up to version 19. This version supports the latest libsecp. | |
| - Support Coincurve up to version 20. This version supports the latest libsecp. |
| @@ -1,2 +1,2 @@ | |||
| coincurve>=15.0,<19 | |||
| coincurve>=15.0,<=19 | |||
There was a problem hiding this comment.
Suggested change
| coincurve>=15.0,<=19 | |
| coincurve>=15.0,<21 |
Owner
Author
|
Yes, will do. |
Merged
Owner
Author
|
Superseded by #43. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39.