Add context manager methods to the FeatureDB class#241
Open
Fan-iX wants to merge 1 commit intodaler:masterfrom
Open
Add context manager methods to the FeatureDB class#241Fan-iX wants to merge 1 commit intodaler:masterfrom
Fan-iX wants to merge 1 commit intodaler:masterfrom
Conversation
This PR add context manager methods `__enter__` and `__exit__` to the FeatureDB class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I use a python web server to serve gff data with
gffutils.In my application, a
FeatureDBinstance is created on every web request, and I notice that I have to.close()theFeatureDB.connexplictly, or there could be a file descriptor leak / memory leak.This PR add context manager methods
__enter__and__exit__to the FeatureDB class, so that we can manage it within awithstatement:instead of