Allowed user to override conventions for primary key#72
Open
Wayne-Mather wants to merge 5 commits intocsharpfritz:mainfrom
Open
Allowed user to override conventions for primary key#72Wayne-Mather wants to merge 5 commits intocsharpfritz:mainfrom
Wayne-Mather wants to merge 5 commits intocsharpfritz:mainfrom
Conversation
…n [Key] annotation or id as the name
…n [Key] annotation or id as the name Reflection for property is case insensitive, so don't need Id twice
…ions_and_overrides' into features/add_primary_key_conventions_and_overrides
Author
|
Well the squash didn't go so well in clearing up the commit history. Not a git guru by any means so I don't use rebase as I often get it wrong |
Contributor
|
Hi @Wayne-Mather not sure what you think went wrong. But usually when you use rebase -i and changed the commit history. You need to push --force those changes otherwise it will try to sync the history and probably create some duplicates. If this is stating the obvious, just ignore this. ps don't be afraid to lose things in git all commits are still there and can be found back with git reflog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the code was check for property called id and assume thats the primary key, or find the data annotation [Key].
If the user does not have any of those the application failed. This now allows a convention to be created out-of-the-box and the user to override that convention if necessary.
It also changes the order so if there is a [Key] annotation, that is used by default.