Making it so when no search occurs, 'no results' is not *always* thrown.#10
Open
JoshKoberstein wants to merge 2 commits intocroxton:masterfrom
Open
Making it so when no search occurs, 'no results' is not *always* thrown.#10JoshKoberstein wants to merge 2 commits intocroxton:masterfrom
JoshKoberstein wants to merge 2 commits intocroxton:masterfrom
Conversation
…ccurring, no results is not thrown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no search is occurring, the plugin should optionally throw a 'no results' response because always doing so causes conflict with other channel:entries parameters.
For instance, say we have the following code:
{exp:search_fields search:title="{document_route_keywords}" required="n" no_results="y" search:document_content="{document_route_keywords}" search:document_document_excerpt="{document_route_keywords}" operator="OR" channel="document" parse="inward"} {exp:channel:entries entry_id="{search_results}" channel="document" status="open" dynamic="no" paginate="bottom" limit="5" category="{document_route_category_ids}"}`
This is code for a documents section that is filterable by keyword and multiple document category groups.
If there are no keywords present ( {document_route_keywords} ),
no_resultswill be returned. However, I may still want to view documents of a certain category.I added a 'required' parameter to specify whether or not performing a search is required. If required and no search parameters are present, no_results will be set to true. If not required and no search parameters are present, the placeholder variable will be set to a blank string so that additional channel entries loop parameters will be processed.