Replace grand-central Ingress with HTTPRoute and Traefik Middlewares#837
Open
tomach wants to merge 5 commits into
Open
Replace grand-central Ingress with HTTPRoute and Traefik Middlewares#837tomach wants to merge 5 commits into
tomach wants to merge 5 commits into
Conversation
3ab31e1 to
bf3789f
Compare
bf3789f to
6946339
Compare
Contributor
|
Caught some errors on dev on /auth and /health endpoints: According to the W3C and MDN web specs, the Access-Control-Allow-Origin header can only contain a single origin, the wildcard *, or null. It cannot accept a comma-separated list of multiple origins. When you pass a list, browsers reject it as an invalid value, causing the CORS block. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Extends the existing
exposurefield support to grand-central. Whenspec.cluster.exposure: traefik, grand-central is now exposed through the Gateway API (HTTPRoute) and three Traefik Middlewares instead of an nginxIngress. The defaultloadbalancerpath is unchanged.grand-central.pyadds builders forHTTPRoute,compress-js,buffering, andip-allowlistMiddlewares; addscreate_grand_central_exposure(routing resources only, no deployment/service) and delete helpers for both pathsexposure.py-ChangeExposureSubHandlernow also switches grand-central resources when the exposure field changesoperations.py-suspend_or_start_grand_centraldeletes routing resources on suspend and recreates them on resume, respecting the active exposure modehandle_update_allowed_cidrs.pypatches theip-allowlistMiddleware instead of the Ingress annotation whenexposure=traefikgateway.networking.k8s.io/httproutesandtraefik.io/middlewaresChecklist
CHANGES.rst