Making config file path dynamic #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mubangizi
requested changes
Mar 11, 2024
Collaborator
Mubangizi
left a comment
Mubangizi
left a comment
There was a problem hiding this comment.
hey @LanternNassi, great work, just a little changes
|
|
||
|
|
||
| dotenv_path = join(dirname(__file__), '.env') | ||
| load_dotenv(dotenv_path) |
|
|
||
|
|
||
| def write_config(key, value, should_update=True): | ||
| def write_config(key, value, should_update=True , crane_dir = get_base_dir()): |
Collaborator
There was a problem hiding this comment.
Please revert this, we talked about removing crane_dir key
|
|
||
|
|
||
| def read_config(): | ||
| def read_config(crane_config = get_base_dir()): |
Collaborator
There was a problem hiding this comment.
Please remove crane_dir variable
|
|
||
| CONFIG_FILE = 'config' | ||
|
|
||
| dotenv_path = join(dirname(__file__), '.env') |
Collaborator
There was a problem hiding this comment.
This shouldn't be here, rather in the initial file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is meant to enable a user create and use a config file in another location of covienience . The default config file location is used if there is no config path specified for the command
Trello ticket
https://trello.com/c/XSh7tm8X/1825-make-config-file-path-dynamic