add ability to specify settlement package information in ethflow package#70
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
anxolin
approved these changes
Apr 14, 2026
|
@kaze-cow sould we merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the downstream staging env mainnet PR we need to be able to override the settlement package--specifically in this case for use overriding the source preset. Otherwise, the
mainnamespace settlement package needs to be deployed, and this is a problem for networks where we deploystagingfirst (or othrewise, have not yet deployed themainproduction of the settlement package)the reason this error occurred in the first place without being caught was due to a holdover in my local cannon registry due to previous testing.