Skip to content

Comments

Remove unused groupID argument for DCP#8069

Open
torcolvin wants to merge 3 commits intomainfrom
dcp-remove-unused-arg
Open

Remove unused groupID argument for DCP#8069
torcolvin wants to merge 3 commits intomainfrom
dcp-remove-unused-arg

Conversation

@torcolvin
Copy link
Collaborator

  • Remove unused groupID argument for DCP
  • Fix gitignore to not ignore directories (fix for my editor to find the files)

This is some refactoring ahead of other DCP changes. The group ID is not used, we only use the checkpoint prefix.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

Copilot AI review requested due to automatic review settings February 17, 2026 21:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors DCP client configuration to remove the unused GroupID option (using checkpoint prefixes instead) and adjusts .gitignore entries intended to avoid ignoring tool directories.

Changes:

  • Remove GroupID from base.DCPClientOptions and update DCP option builders/call sites (resync, attachment migration, attachment compaction, cache perf tool).
  • Update tests that construct DCP client options to no longer pass groupID.
  • Modify .gitignore patterns related to tool binaries/directories.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tools/cache_perf_tool/dcpDataGeneration.go Stops populating removed DCPClientOptions.GroupID in test client options.
db/background_mgr_resync_dcp.go Removes groupID arg from resync DCP option builder; updates call site and comment.
db/background_mgr_resync_dcp_test.go Updates resync test to match new options builder signature.
db/background_mgr_attachment_migration.go Removes groupID arg from migration DCP option builder; updates call site and comment.
db/background_mgr_attachment_migration_test.go Updates migration test to match new options builder signature.
db/attachment_compaction.go Removes groupID arg from compaction DCP option builder; updates call sites.
db/attachment_compaction_test.go Updates compaction test to match new options builder signature.
base/gocb_dcp_feed.go Stops setting removed DCPClientOptions.GroupID in feed startup options.
base/gocb_dcp_client.go Removes GroupID from DCPClientOptions struct definition.
.gitignore Attempts to refine ignore rules for tool artifacts/directories.
Comments suppressed due to low confidence (1)

base/gocb_dcp_feed.go:104

  • StartGocbDCPFeed still accepts groupID, but it’s no longer used after removing GroupID from DCPClientOptions. With unparam enabled in golangci-lint, this is likely to fail lint. Either remove the groupID parameter from StartGocbDCPFeed (and update callers), or explicitly mark it used (e.g. _ = groupID) if the signature must remain for compatibility.
	options := DCPClientOptions{
		MetadataStoreType: metadataStoreType,
		DbStats:           dbStats,
		CollectionIDs:     collectionIDs,
		AgentPriority:     gocbcore.DcpAgentPriorityMed,
		CheckpointPrefix:  args.CheckpointPrefix,
	}

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants