Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Rust workspace configuration to relocate core crates under a crates/ directory, aligning workspace membership and path dependencies with the new layout (noted as a revert of #508).
Changes:
- Move workspace member crate paths from root-level directories to
crates/*. - Update workspace path dependencies (
cot,cot_core,cot_codegen,cot_macros) to point tocrates/*.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Bencher Report| Branch | revert-508-revert-reorg |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 6,587.70 µs(+11.07%)Baseline: 5,931.31 µs | 7,045.05 µs (93.51%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1,109.90 µs(+8.07%)Baseline: 1,027.03 µs | 1,177.60 µs (94.25%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 1,015.90 µs(+7.33%)Baseline: 946.49 µs | 1,076.91 µs (94.33%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 981.55 µs(+8.09%)Baseline: 908.05 µs | 1,037.10 µs (94.64%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 17,263.00 µs(-1.52%)Baseline: 17,530.12 µs | 20,637.49 µs (83.65%) |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #508