Conversation
8ce93ad to
1c442a5
Compare
|
| Branch | config-reorganization |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 6.61 ms(+11.45%)Baseline: 5.93 ms | 7.04 ms (93.90%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1.09 ms(+5.94%)Baseline: 1.03 ms | 1.18 ms (92.43%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 1.01 ms(+7.06%)Baseline: 0.95 ms | 1.08 ms (94.00%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 1.00 ms(+10.20%)Baseline: 0.91 ms | 1.04 ms (96.53%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 17.32 ms(-1.39%)Baseline: 17.56 ms | 20.69 ms (83.68%) |
1c442a5 to
277c4e0
Compare
There was a problem hiding this comment.
Pull request overview
Moves assorted tool and automation configuration files out of the repository root into dedicated subdirectories (primarily .config/ and .cargo/), updating CI and developer tooling to reference the new locations. This follows PR #506’s goal of reducing root-directory clutter.
Changes:
- Update pre-commit hooks to use configs from
.config/(yamlfmt, djLint). - Update GitHub Actions workflows to reference relocated configs (cargo-deny, release-plz).
- Add new config files under
.config/and.cargo/.
Reviewed changes
Copilot reviewed 3 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .pre-commit-config.yaml | Points yamlfmt and djLint hooks at config files under .config/. |
| .github/workflows/rust.yml | Updates cargo-deny invocation to use a config path (currently mismatched). |
| .github/workflows/release-plz.yml | Configures release-plz action to load .cargo/release-plz.toml. |
| .config/yamlfmt.yml | Adds yamlfmt configuration file under .config/. |
| .config/insta.yaml | Adds insta/cargo-insta configuration under .config/. |
| .config/djlint.toml | Adds djLint configuration file under .config/. |
| .cargo/release-plz.toml | Adds release-plz configuration under .cargo/. |
| .cargo/deny.toml | Adds cargo-deny configuration under .cargo/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
m4tx
left a comment
There was a problem hiding this comment.
Why is insta.yaml being moved to .config, but release-plz.toml and deny.toml are moved to .cargo? Feels like all of these should be in one directory for consistency. Otherwise, LGTM.
Follow-up to #506