Skip to content

[2] Feat: Manifest validation#48

Open
redaranj wants to merge 1 commit intocontentauth:mainfrom
redaranj:feature/manifest-validation
Open

[2] Feat: Manifest validation#48
redaranj wants to merge 1 commit intocontentauth:mainfrom
redaranj:feature/manifest-validation

Conversation

@redaranj
Copy link
Member

@redaranj redaranj commented Mar 5, 2026

Changes in this pull request

  • Adds manifest validator to check correctness before passing the structure to the underlying library
  • Adds manifest convenience functions
  • Updates for 2.3 spec compliance

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • All applicable changes have been documented
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 84.25926% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.90%. Comparing base (e62ba32) to head (647d354).

Files with missing lines Patch % Lines
...org/contentauth/c2pa/manifest/ManifestValidator.kt 73.17% 16 Missing and 6 partials ⚠️
...g/contentauth/c2pa/manifest/AssertionDefinition.kt 62.74% 8 Missing and 11 partials ⚠️
...n/org/contentauth/c2pa/manifest/ActionAssertion.kt 34.61% 17 Missing ⚠️
...tentauth/c2pa/manifest/ManifestValidationResult.kt 57.14% 2 Missing and 1 partial ⚠️
...ary/src/main/kotlin/org/contentauth/c2pa/Action.kt 85.71% 2 Missing ⚠️
...ry/src/main/kotlin/org/contentauth/c2pa/Builder.kt 75.00% 1 Missing and 1 partial ⚠️
...kotlin/org/contentauth/c2pa/manifest/Ingredient.kt 83.33% 2 Missing ⚠️
...n/kotlin/org/contentauth/c2pa/manifest/TimeType.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #48      +/-   ##
============================================
+ Coverage     65.78%   69.90%   +4.12%     
- Complexity        9       40      +31     
============================================
  Files            56       58       +2     
  Lines          1920     2190     +270     
  Branches        218      250      +32     
============================================
+ Hits           1263     1531     +268     
+ Misses          510      502       -8     
- Partials        147      157      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@redaranj redaranj force-pushed the feature/manifest-validation branch 2 times, most recently from 1405f38 to 7c055b2 Compare March 12, 2026 19:11
@redaranj redaranj force-pushed the feature/manifest-validation branch from 7c055b2 to 33a51a8 Compare March 26, 2026 12:46
… and action types, and integrate validation into the builder workflow
@redaranj redaranj force-pushed the feature/manifest-validation branch from 33a51a8 to 647d354 Compare March 26, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant