Migration for nested elements#75
Open
cboelter wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #74 here is a new proposal for the nested fragments migration. After checking the migration and the result a bit deeper I saw that nested grids where not detected correctly. So I asked claude to build a better implementation with me. Now it supports nested grids and migrates also the gridSeparators to element_groups.
If there is a separator and before the separator are more than one Elements these elements are also put into a element_group. I'm not 100% sure that this is the correct behaviour. I think a better approach would be to get the grid configuration and then decide which elements would be grouped into element_groups? Maybe you have some input for me :-)