Skip to content

Implementation of nested fragments#73

Closed
cboelter wants to merge 7 commits into
contao-bootstrap:developfrom
cboelter:develop
Closed

Implementation of nested fragments#73
cboelter wants to merge 7 commits into
contao-bootstrap:developfrom
cboelter:develop

Conversation

@cboelter
Copy link
Copy Markdown

@cboelter cboelter commented Apr 13, 2026

Hi,

as discussed I have updated your implementation for nested fragments. I have done the following changes:

  • Split the template logic for frontend and backend in two separate templates
  • Change the originale template as it has not worked properly with the grid separator logic
  • Added a listener to show the grid_parent field in separators only if there is the old start / stop used
  • Changed the parent retrivial for the separator
  • Added an optional migration to migrate all start / stop elements to the new wrappers
  • Synced develop with master

… grid field only on old start / stop elements, change original nested element to get working with separator elements
@dmolineus
Copy link
Copy Markdown
Member

I updated the develop branch containing the changes of the master branch and got phpcs working again. Could you rebase your changes on the latest develop branch please?

@dmolineus dmolineus closed this Apr 13, 2026
@dmolineus dmolineus reopened this Apr 13, 2026
dependabot Bot and others added 4 commits April 13, 2026 16:58
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 6 to 7.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v6...v7)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '7'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
# Conflicts:
#	.phpcq.lock
#	.phpcq.yaml.dist
#	composer.json
@cboelter
Copy link
Copy Markdown
Author

@dmolineus hopefully rebased correctly 😨 I've tried to run phpcq after rebase, but I always get the following error:
COMMAND: php vendor/bin/phpcq exec phpcs
ERROR: Referenced sniff "Doctrine" does not exist.

@dmolineus
Copy link
Copy Markdown
Member

The rebase doesn't seem to be correct (too many commits already being part of develop being listed as commits). Therefore I created a rebased version #74 as ongoing pull request.

You should use php vendor/bin/phpcq run phpcs. The doctrine coding standard hast du be injected into the phpcs configuration. That does not work when calling exec.

@dmolineus dmolineus closed this Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants