[DNM] try defining interfaces locally#254
Closed
thaJeztah wants to merge 1 commit intocontainerd:mainfrom
Closed
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
local_wasm_interface
branch
from
d6810ba to
d56ee7e
Compare
Member
|
Let's close this for now since we're not actively working on this and have a merged build flag to disable WASM support altogether. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This very likely doesn't compile; this was some initial quick attempt to see if it would be possible to define the interfaces as part of NRI instead of pulling in an externally defined interface (which would open up the API being implicitly modified through the external dependencies).